Support maximize window command.

chrome/browser/ui/gtk/browser_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
 
 #include <dlfcn.h>
 #include <gdk/gdkkeysyms.h>
 
 #include <algorithm>
@@ skipping 1035 matching lines @@
 
 void BrowserWindowGtk::ShowAboutChromeDialog() {
   ShowAboutDialogForProfile(window_, browser_->profile(), browser_.get());
 }
 
 void BrowserWindowGtk::ShowUpdateChromeDialog() {
   UpdateRecommendedDialog::Show(window_);
 }
 
 void BrowserWindowGtk::ShowTaskManager() {
   TaskManagerGtk::Show(false);

[kkania, 2012/06/01 04:14:03]

normally you don't sync a branch with a CL in review to avoid messing up the
diffs, but sometimes you can't help it

 }
 
 void BrowserWindowGtk::ShowBackgroundPages() {
   TaskManagerGtk::Show(true);
 }
 
 void BrowserWindowGtk::ShowBookmarkBubble(const GURL& url,
                                           bool already_bookmarked) {
   toolbar_->GetLocationBarView()->ShowStarBubble(url, !already_bookmarked);
 }
@@ skipping 529 matching lines @@
     } else {
       fullscreen_exit_bubble_type_ =
           FEB_TYPE_BROWSER_FULLSCREEN_EXIT_INSTRUCTION;
       gtk_widget_show(titlebar_widget());
       fullscreen_exit_bubble_.reset();
       UpdateCustomFrame();
       ShowSupportedWindowFeatures();
     }
   }
 
+  if (event->changed_mask & GDK_WINDOW_STATE_MAXIMIZED) {

[Ben Goodger (Google), 2012/06/01 17:10:11]

is this already supported on other platforms?

can we avoid using notifications?

[zori, 2012/06/02 01:20:54]

Since other platforms execute the maximize operation synchronously, the testing
automation provider in chrome is able to send a 'success' JSON reply right after
invoking the maximize() command on the browser window. On Linux, however, this
happens asynchronously, so we should wait for the gtk event indicating
completion of maximization. Could you, perhaps, suggest a better approach than
using the Notification Service?

+    content::NotificationService::current()->Notify(
+        chrome::NOTIFICATION_BROWSER_WINDOW_MAXIMIZED,
+        content::Source<BrowserWindowGtk>(this),

[kkania, 2012/06/01 04:14:03]

Just use BrowserWindow

[zori, 2012/06/02 01:20:54]

Done.

+        content::NotificationService::NoDetails());
+  }
+
   titlebar_->UpdateCustomFrame(UseCustomFrame() && !IsFullscreen());
   UpdateWindowShape(bounds_.width(), bounds_.height());
   SaveWindowPosition();
   return FALSE;
 }
 
 // Callback for the delete event.  This event is fired when the user tries to
 // close the window (e.g., clicking on the X in the window manager title bar).
 gboolean BrowserWindowGtk::OnMainWindowDeleteEvent(GtkWidget* widget,
                                                    GdkEvent* event) {
@@ skipping 973 matching lines @@
           wm_type == ui::WM_OPENBOX ||
           wm_type == ui::WM_XFWM4);
 }
 
 // static
 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
   BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser);
   browser_window_gtk->Init();
   return browser_window_gtk;
 }