Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: bin/builtin.h

Issue 10388242: Minor restructure some of the builtin library processing code (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | bin/builtin.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/builtin.h
===================================================================
--- bin/builtin.h (revision 8133)
+++ bin/builtin.h (working copy)
@@ -21,13 +21,17 @@
class Builtin {
public:
+ // Note: Changes to this enum should be accompanied with changes to
+ // the builtin_libraries_ array in builtin.cc and builtin_nolib.cc.
enum BuiltinLibraryId {
- kBuiltinLibrary,
+ kBuiltinLibrary = 0,
+ kJsonLibrary,
+ kUriLibrary,
kCryptoLibrary,
kIOLibrary,
- kJsonLibrary,
- kUriLibrary,
kUtfLibrary,
+
+ kInvalidLibrary,
};
static Dart_Handle Source(BuiltinLibraryId id);
@@ -48,6 +52,13 @@
static const char uri_source_[];
static const char utf_source_[];
+ typedef struct {
+ const char* url_;
+ const char* source_;
+ bool has_natives_;
+ } builtin_lib_props;
+ static builtin_lib_props builtin_libraries_[];
+
DISALLOW_ALLOCATION();
DISALLOW_IMPLICIT_CONSTRUCTORS(Builtin);
};
« no previous file with comments | « no previous file | bin/builtin.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698