chrome/browser/protector/settings_change_global_error.cc - Issue 10388239: Make NetworkProfileBubble not use BrowserList::GetLastActive() as much. Instead pass it a profile a…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/protector/settings_change_global_error.cc

Issue 10388239: Make NetworkProfileBubble not use BrowserList::GetLastActive() as much. Instead pass it a profile a… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/protector/settings_change_global_error.h ('k') | chrome/browser/ui/browser_list.h » ('j') | chrome/browser/ui/views/network_profile_bubble.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/protector/settings_change_global_error.cc

===================================================================

--- chrome/browser/protector/settings_change_global_error.cc (revision 138102)

+++ chrome/browser/protector/settings_change_global_error.cc (working copy)

@@ -204,7 +204,7 @@

}

void SettingsChangeGlobalError::OnBrowserSetLastActive(

- const Browser* browser) {

+ Browser* browser) {

if (show_on_browser_activation_ && browser && browser->is_type_tabbed()) {

// A tabbed browser window got activated, show the error bubble again.

// Calling ShowBubble() immediately from here does not always work because