Make NetworkProfileBubble not use BrowserList::GetLastActive() as much. Instead pass it a profile a…

chrome/browser/ui/startup/startup_browser_creator_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 85 matching lines @@
         return *i;
     }
     return NULL;
   }
 };
 
 class OpenURLsPopupObserver : public BrowserList::Observer {
  public:
   OpenURLsPopupObserver() : added_browser_(NULL) { }
 
-  virtual void OnBrowserAdded(const Browser* browser) {
+  virtual void OnBrowserAdded(Browser* browser) {
     added_browser_ = browser;
   }
 
-  virtual void OnBrowserRemoved(const Browser* browser) { }
+  virtual void OnBrowserRemoved(Browser* browser) { }
 
-  const Browser* added_browser_;
+  Browser* added_browser_;
 };
 
 // Test that when there is a popup as the active browser any requests to
 // StartupBrowserCreatorImpl::OpenURLsInBrowser don't crash because there's no
 // explicit profile given.
 IN_PROC_BROWSER_TEST_F(StartupBrowserCreatorTest, OpenURLsPopup) {
   std::vector<GURL> urls;
   urls.push_back(GURL("http://localhost"));
 
   // Note that in our testing we do not ever query the BrowserList for the "last
@@ skipping 561 matching lines @@
   ASSERT_EQ(1u, browser::GetBrowserCount(profile_urls));
   new_browser = FindOneOtherBrowserForProfile(profile_urls, NULL);
   ASSERT_TRUE(new_browser);
   ASSERT_EQ(1, new_browser->tab_count());
   EXPECT_EQ(GURL(chrome::kChromeUINewTabURL),
             new_browser->GetWebContentsAt(0)->GetURL());
   EXPECT_EQ(1U, new_browser->GetTabContentsWrapperAt(0)->infobar_tab_helper()->
             infobar_count());
 }
 #endif  // !OS_CHROMEOS