Make cloud print dialog creation function not use browser list, instead obtain profile and parent w…

chrome/browser/printing/print_dialog_cloud_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_dialog_cloud.h"
 #include "chrome/browser/printing/print_dialog_cloud_internal.h"
 
 #include <string>
 #include <vector>
 
@@ skipping 299 matching lines @@
     string16 mock_print_ticket;
     std::string mock_file_type;
     MockCloudPrintFlowHandler* handler =
         new MockCloudPrintFlowHandler(mock_path, mock_print_ticket,
                                       mock_title, mock_file_type,
                                       false, base::Closure());
     mock_flow_handler_ = handler->AsWeakPtr();
     EXPECT_CALL(*mock_flow_handler_.get(), SetDialogDelegate(_));
     EXPECT_CALL(*mock_flow_handler_.get(), SetDialogDelegate(NULL));
     delegate_.reset(new CloudPrintWebDialogDelegate(
-        mock_flow_handler_.get(), 100, 100, std::string(), true, false));
+        mock_flow_handler_.get(), 100, 100, std::string(), false));

[Albert Bodenhamer, 2012/05/21 22:36:55]

You'll need to drop the width and height and pass in a file path.

This and the accompanying change to the constructor also changes the behavior of
the test.  It used to specify modal, while this will result in non-modal.  There
were some simplifications to the code a while back that I THINK mean it's no
longer relevant.

   }
 
   virtual void TearDown() {
     delegate_.reset();
     if (mock_flow_handler_)
       delete mock_flow_handler_.get();
   }
 
   MessageLoopForUI message_loop_;
   content::TestBrowserThread ui_thread_;
@@ skipping 22 matching lines @@
   delegate_->GetWebUIMessageHandlers(&handlers);
   delegate_.reset();
   EXPECT_THAT(mock_flow_handler_.get(), NotNull());
 }
 
 // Testing for ExternalWebDialogUI needs a mock WebContents, mock
 // CloudPrintWebDialogDelegate (provided through the mock
 // tab_contents)
 
 // Testing for PrintDialogCloud needs a mock Browser.