Make cloud print dialog creation function not use browser list, instead obtain profile and parent w…

chrome/browser/printing/print_dialog_cloud.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRINTING_PRINT_DIALOG_CLOUD_H_
 #define CHROME_BROWSER_PRINTING_PRINT_DIALOG_CLOUD_H_
 #pragma once
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/string16.h"
+#include "ui/gfx/native_widget_types.h"
 
 class FilePath;
 class CommandLine;
 
+namespace content {
+class BrowserContext;
+}
+
 namespace print_dialog_cloud {
 
 // Creates a print dialog to print a file on disk.
 // Called on the FILE or UI thread. Even though this may start up a modal
 // dialog, it will return immediately. The dialog is handled asynchronously.
-void CreatePrintDialogForFile(const FilePath& path_to_file,
+void CreatePrintDialogForFile(content::BrowserContext* browser_context,
+                              gfx::NativeWindow modal_parent,

[Albert Bodenhamer, 2012/05/21 22:36:55]

In Windows it's possible to create a modal dialog that uses the Desktop as a
parent by specifying a NULL parent.

We're not doing that anywhere (and it wouldn't be a good thing to do anyway) but
I could imagine someone passing in a NULL modal_parent and expecting that
behavior.

Maybe mention in the comments that a NULL modal_parent will result in a modeless
dialog?

+                              const FilePath& path_to_file,
                               const string16& print_job_title,
                               const string16& print_ticket,
                               const std::string& file_type,
-                              bool modal,
                               bool delete_on_close);
 
 // Creates a print dialog to print data in RAM.
 // Called on the FILE or UI thread. Even though this may start up a modal
 // dialog, it will return immediately. The dialog is handled asynchronously.
-void CreatePrintDialogForBytes(scoped_refptr<base::RefCountedBytes> data,
+void CreatePrintDialogForBytes(content::BrowserContext* browser_context,
+                               gfx::NativeWindow modal_parent,
+                               scoped_refptr<base::RefCountedBytes> data,
                                const string16& print_job_title,
                                const string16& print_ticket,
-                               const std::string& file_type,
-                               bool modal);
+                               const std::string& file_type);
 
 // Parse switches from command_line and display the print dialog as appropriate.
+// Uses the default profile.
 bool CreatePrintDialogFromCommandLine(const CommandLine& command_line);
 
 // Creates a dialog for signing into cloud print.
 // The dialog will call |callback| when complete.
 // Called on the UI thread. Even though this starts up a modal
 // dialog, it will return immediately. The dialog is handled asynchronously.
-void CreateCloudPrintSigninDialog(const base::Closure& callback);
+void CreateCloudPrintSigninDialog(content::BrowserContext* browser_context,
+                                  gfx::NativeWindow modal_parent,
+                                  const base::Closure& callback);
 
 }  // end namespace
 
 #endif  // CHROME_BROWSER_PRINTING_PRINT_DIALOG_CLOUD_H_