Make cloud print dialog creation function not use browser list, instead obtain profile and parent w…

chrome/browser/printing/print_dialog_cloud_interative_uitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/printing/print_dialog_cloud.h"
 #include "chrome/browser/printing/print_dialog_cloud_internal.h"
 
 #include <functional>
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/memory/singleton.h"
 #include "base/path_service.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/printing/cloud_print/cloud_print_url.h"
+#include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 170 matching lines @@
 
     CreateDialogForTest();
   }
 
   void CreateDialogForTest() {
     FilePath path_to_pdf =
         test_data_directory_.AppendASCII("printing/cloud_print_uitest.pdf");
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         base::Bind(&internal_cloud_print_helpers::CreateDialogFullImpl,
+                   browser()->profile(), browser()->window()->GetNativeHandle(),
                    path_to_pdf, string16(), string16(),
-                   std::string("application/pdf"), true, false));
+                   std::string("application/pdf"), false));
   }
 
   bool handler_added_;
   std::string scheme_;
   std::string host_name_;
   FilePath test_data_directory_;
   AutoQuitDelegate delegate_;
 };
 
 net::URLRequestJob* PrintDialogCloudTest::Factory(net::URLRequest* request,
                                                   const std::string& scheme) {
   if (request &&
       (request->url() == TestController::GetInstance()->expected_url())) {
     if (TestController::GetInstance()->use_delegate())
       request->set_delegate(TestController::GetInstance()->delegate());
     TestController::GetInstance()->set_result(true);
     return new SimpleTestJob(request);
   }
   return new net::URLRequestTestJob(request,
                                     net::URLRequestTestJob::test_headers(),
                                     "", true);
 }
 
 #if defined(OS_WIN)
 #define MAYBE_HandlersRegistered FLAKY_HandlersRegistered
 #else
 #define MAYBE_HandlersRegistered HandlersRegistered
 #endif
 IN_PROC_BROWSER_TEST_F(PrintDialogCloudTest, MAYBE_HandlersRegistered) {
-  BrowserList::SetLastActive(browser());
-  ASSERT_TRUE(BrowserList::GetLastActive());
-
   AddTestHandlers();
 
   TestController::GetInstance()->set_use_delegate(true);
 
   ui_test_utils::RunMessageLoop();
 
   ASSERT_TRUE(TestController::GetInstance()->result());
 
   // Close the dialog before finishing the test.
   ui_test_utils::WindowedNotificationObserver tab_closed_observer(
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::NotificationService::AllSources());
 
   // Can't use ui_test_utils::SendKeyPressSync or
   // ui_test_utils::SendKeyPressAndWait due to a race condition with closing
   // the window. See http://crbug.com/111269
   BrowserWindow* window = browser()->window();
   ASSERT_TRUE(window);
   gfx::NativeWindow native_window = window->GetNativeHandle();
   ASSERT_TRUE(native_window);
   bool key_sent = ui_controls::SendKeyPress(native_window, ui::VKEY_ESCAPE,
                                             false, false, false, false);
   EXPECT_TRUE(key_sent);
   if (key_sent)
     tab_closed_observer.Wait();
 }