Fix crash in policy code caused by early shutdown.

chrome/browser/browser_process_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // When each service is created, we set a flag indicating this. At this point,
 // the service initialization could fail or succeed. This allows us to remember
 // if we tried to create a service, and not try creating it over and over if
 // the creation failed.
 
 #ifndef CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_
@@ skipping 136 matching lines @@
   void ApplyDefaultBrowserPolicy();
 
   bool created_metrics_service_;
   scoped_ptr<MetricsService> metrics_service_;
 
   scoped_ptr<IOThread> io_thread_;
 
   bool created_watchdog_thread_;
   scoped_ptr<WatchDogThread> watchdog_thread_;
 
+  // Must be destroyed after |policy_service_| if StartTearDown() isn't invoked
+  // during to an early shutdown.

[Mattias Nissler (ping if slow), 2012/05/21 16:33:37]

nit: grammar.

Also, can you please file a bug for fixing up initialization and cleanup order
for the policy stuff?

[Joao da Silva, 2012/05/21 17:14:34]

Done.

+  bool created_browser_policy_connector_;
+  scoped_ptr<policy::BrowserPolicyConnector> browser_policy_connector_;
+
   // Must be destroyed after |local_state_|.
   scoped_ptr<policy::PolicyService> policy_service_;
 
   bool created_profile_manager_;
   scoped_ptr<ProfileManager> profile_manager_;
 
   bool created_local_state_;
   scoped_ptr<PrefService> local_state_;
 
   bool created_icon_manager_;
   scoped_ptr<IconManager> icon_manager_;
 
   scoped_refptr<ExtensionEventRouterForwarder>
       extension_event_router_forwarder_;
 
   scoped_ptr<RemoteDebuggingServer> remote_debugging_server_;
 
-  bool created_browser_policy_connector_;
-  scoped_ptr<policy::BrowserPolicyConnector> browser_policy_connector_;
-
   scoped_refptr<printing::PrintPreviewTabController>
       print_preview_tab_controller_;
 
   scoped_ptr<printing::BackgroundPrintingManager> background_printing_manager_;
 
   scoped_ptr<ui::Clipboard> clipboard_;
 
   scoped_ptr<VariationsService> variations_service_;
 
   // Manager for desktop notification UI.
@@ skipping 73 matching lines @@
 #endif
 
   // TODO(eroman): Remove this when done debugging 113031. This tracks
   // the callstack which released the final module reference count.
   base::debug::StackTrace release_last_reference_callstack_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserProcessImpl);
 };
 
 #endif  // CHROME_BROWSER_BROWSER_PROCESS_IMPL_H_