Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1373)

Unified Diff: test/mjsunit/error-tostring.js

Issue 10388208: Add test case for custom error's toString. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/error-tostring.js
diff --git a/test/mjsunit/error-tostring.js b/test/mjsunit/error-tostring.js
index a28564144f8bcd4267a27dc1e4a9f797d68ab74f..59e7149c21ad9f8a8fe51620f74f209a886f6e07 100644
--- a/test/mjsunit/error-tostring.js
+++ b/test/mjsunit/error-tostring.js
@@ -83,3 +83,22 @@ assertEquals(["Error: e2",[1,3,4]], testErrorToString(undefined, "e2"));
assertEquals(["null: e2",[1,2,3,4]], testErrorToString(null, "e2"));
assertEquals(["e2",[1,2,3,4]], testErrorToString("", "e2"));
assertEquals(["e1: e2",[1,2,3,4]], testErrorToString("e1", "e2"));
+
+
+// Test that a custom error object does not use Error.prototype.toString.
+
+function MyError(name, message) {
+ this.name = name;
+ this.message = message;
+}
+
+MyError.prototype = Object.create(Error.prototype);
+MyError.prototype.toString = function() {
+ return 'MyError toString';
+};
+
+try {
+ throw new MyError('name', 'message');
+} catch (e) {
+ assertEquals('MyError toString', e.toString());
arv (Not doing code reviews) 2012/05/21 16:40:03 I don't think this tests the right thing. This jus
+}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698