[sync] Add --port and --xmpp-port parameters to run_testserver.cc

net/test/local_sync_test_server.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/test/local_sync_test_server.h"
+
+#include "base/values.h"
+#include "net/test/test_server.h"
+
+namespace net {
+
+LocalSyncTestServer::LocalSyncTestServer()
+    : LocalTestServer(net::TestServer::TYPE_SYNC,
+                      net::TestServer::kLocalhost,
+                      FilePath()),
+      xmpp_port_(0) {}
+
+LocalSyncTestServer::LocalSyncTestServer(uint16 port, uint16 xmpp_port)
+    : LocalTestServer(net::TestServer::TYPE_SYNC,
+                      net::TestServer::kLocalhost,
+                      FilePath()),
+      xmpp_port_(xmpp_port) {
+  SetPort(port);
+}
+
+LocalSyncTestServer::~LocalSyncTestServer() {}
+
+bool LocalSyncTestServer::GenerateArguments(
+    base::DictionaryValue* arguments) const {
+  BaseTestServer::GenerateArguments(arguments);
+  if (xmpp_port_ != 0) {
+    arguments->SetInteger("xmpp-port", xmpp_port_);
+  }
+  return true;
+}
+
+void LocalSyncTestServer::CleanUpWhenStoppingServer() {
+  BaseTestServer::CleanUpWhenStoppingServer();

[akalin, 2012/05/23 06:16:49]

why not LocalTestServer:: here instead? (even if it doesn't explicitly override
that method, it will simply fall back to the BaseTestServer:: version. if it
does override it in the future, that may break this class in subtle ways.)

if you do remove this, make sure you remove the test_server.h include, too.

[Paweł Hajdan Jr., 2012/05/23 06:53:02]

+1

[Raghu Simha, 2012/05/23 19:54:28]

Moot.

[Raghu Simha, 2012/05/23 19:54:28]

Good point. It's moot, though.
 
The include was necessary for TYPE_SYNC and kLocalhost.

+  xmpp_port_ = 0;
+}
+
+}  // namespace net