net/test/OWNERS - Issue 10388206: [sync] Add --port and --xmpp-port parameters to run_testserver.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/test/OWNERS

Issue 10388206: [sync] Add --port and --xmpp-port parameters to run_testserver.cc (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Fix nits Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	1 # General reviewer, except sync-specific bits.

1 phajdan.jr@chromium.org	2 phajdan.jr@chromium.org

	3

	4 # For changes to local_sync_test_server.{h\|cc}.

	5 akalin@chromium.org
	Paweł Hajdan Jr. 2012/05/23 06:53:02 I'm not sure if it's worth it just for two small f I'm not sure if it's worth it just for two small files. How about removing it for now and adding it later when the need is more obvious? Raghu Simha 2012/05/23 19:54:28 The plan is to add it now and remove it later, whe Show quoted text On 2012/05/23 06:53:02, Paweł Hajdan Jr. wrote: > I'm not sure if it's worth it just for two small files. How about removing it > for now and adding it later when the need is more obvious? The plan is to add it now and remove it later, when the sync stuff moves out of net/. This is in keeping with the OWNERS file in net/tools/testserver.
OLD	NEW

« no previous file with comments | « net/net.gyp ('k') | net/test/base_test_server.h » ('j') | net/test/base_test_server.h » ('J')