runtime/vm/scanner.h - Issue 10388179: Reject high- and low-surrogates in escaped code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scanner.h

Issue 10388179: Reject high- and low-surrogates in escaped code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: continue scanning after an invalid escaped code point Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/scanner.h

diff --git a/runtime/vm/scanner.h b/runtime/vm/scanner.h

index d05149c53fff70b8bb313056c61fe8e033f61f44..107ca0236bf4a9db3514de7cbadd2b64ea263175 100644

--- a/runtime/vm/scanner.h

+++ b/runtime/vm/scanner.h

@@ -172,7 +172,7 @@ class Scanner : ValueObject {

bool ScanHexDigits(int min_digits, int max_digits, uint32_t* value);

// Reads an escaped code point from within a string literal.

- bool ScanEscapedCodePoint(uint32_t* escaped_char);

+ void ScanEscapedCodePoint(uint32_t* escaped_char);

// Reads identifier.

RawString* ConsumeIdentChars(bool allow_dollar);

« no previous file with comments | « no previous file | runtime/vm/scanner.cc » ('j') | no next file with comments »