chrome/common/extensions/extension_action.h - Issue 10388160: Only return the visible page actions from PageActionController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_action.h

Issue 10388160: Only return the visible page actions from PageActionController. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: actually fix Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_action.h

diff --git a/chrome/common/extensions/extension_action.h b/chrome/common/extensions/extension_action.h

index 6f40f9a1eae6fcc1ac7033744e86c7ab46c5fe10..a08145957690c4c90940844f6f4f817f81caac4a 100644

--- a/chrome/common/extensions/extension_action.h

+++ b/chrome/common/extensions/extension_action.h

@@ -41,7 +41,7 @@ class ExtensionAction {

~ExtensionAction();

// extension id

- std::string extension_id() const { return extension_id_; }

+ const std::string& extension_id() const { return extension_id_; }

// action id -- only used with legacy page actions API

std::string id() const { return id_; }

« no previous file with comments | « chrome/common/chrome_notification_types.h ('k') | no next file » | no next file with comments »