chrome/browser/resources/ntp4/page_list_view.js - Issue 10388134: [NTP4] Fix appmarklet animation drop bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/ntp4/page_list_view.js

Issue 10388134: [NTP4] Fix appmarklet animation drop bug. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: estade review / behavior change Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/ntp4/page_list_view.js

diff --git a/chrome/browser/resources/ntp4/page_list_view.js b/chrome/browser/resources/ntp4/page_list_view.js

index 4d593217d960b13681a5bd2677df7f8adc957941..f78e8c547fe1ecd9e34f69faec5d581123948cec 100644

--- a/chrome/browser/resources/ntp4/page_list_view.js

+++ b/chrome/browser/resources/ntp4/page_list_view.js

@@ -268,7 +268,7 @@ cr.define('ntp', function() {

assert(app, 'trying to move an app that doesn\'t exist');

app.remove(false);

- this.appsPages[appData.page_index].insertApp(appData);

+ this.appsPages[appData.page_index].insertApp(appData, false);

/**

@@ -442,7 +442,7 @@ cr.define('ntp', function() {

if (app)

app.replaceAppData(appData);

else

- page.insertApp(appData, opt_highlight);

+ page.insertApp(appData, !!opt_highlight);

/**