[NTP4] Fix appmarklet animation drop bug.

chrome/browser/resources/ntp4/tile_page.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp', function() {
   'use strict';
 
   // We can't pass the currently dragging tile via dataTransfer because of
   // http://crbug.com/31037
   var currentlyDraggingTile = null;
@@ skipping 540 matching lines @@
      * instance is removed from the DOM.
      * @private
      */
     tearDown_: function() {
       this.eventTracker.removeAll();
     },
 
     /**
      * Appends a tile to the end of the tile grid.
      * @param {HTMLElement} tileElement The contents of the tile.
-     * @param {?boolean} animate If true, the append will be animated.
+     * @param {boolean} animate If true, the append will be animated.
      * @protected
      */
     appendTile: function(tileElement, animate) {
       this.addTileAt(tileElement, this.tileElements_.length, animate);
     },
 
     /**
      * Adds the given element to the tile grid.
      * @param {Node} tileElement The tile object/node to insert.
      * @param {number} index The location in the tile grid to insert it at.
-     * @param {boolean=} opt_animate If true, the tile in question will be
+     * @param {boolean} animate If true, the tile in question will be
      *     animated (other tiles, if they must reposition, do not animate).
      * @protected
      */
-    addTileAt: function(tileElement, index, opt_animate) {
+    addTileAt: function(tileElement, index, animate) {
       this.classList.remove('animating-tile-page');
-      if (opt_animate)
+      if (animate)
         tileElement.classList.add('new-tile-contents');
 
       // Make sure the index is positive and either in the the bounds of
       // this.tileElements_ or at the end (meaning append).
       assert(index >= 0 && index <= this.tileElements_.length);
 
       var wrapperDiv = new Tile(tileElement);
       // If is out of the bounds of the tile element list, .insertBefore() will
       // act just like appendChild().
       this.tileGrid_.insertBefore(wrapperDiv, this.tileElements_[index]);
       this.calculateLayoutValues_();
       this.heightChanged_();
 
       this.repositionTiles_();
-      this.fireAddedEvent(wrapperDiv, index, !!opt_animate);
+      this.fireAddedEvent(wrapperDiv, index, animate);
     },
 
     /**
      * Notify interested subscribers that a tile has been removed from this
      * page.
      * @param {Tile} tile The newly added tile.
      * @param {number} index The index of the tile that was added.
      * @param {boolean} wasAnimated Whether the removal was animated.
      */
     fireAddedEvent: function(tile, index, wasAnimated) {
@@ skipping 559 matching lines @@
      */
     doDragLeave: function(e) {
       this.cleanupDrag();
     },
 
     /**
      * Performs all actions necessary when a drag enters the tile page.
      * @param {Event} e A mouseover event for the drag enter.
      */
     doDragEnter: function(e) {
-
       // Applies the mask so doppleganger tiles disappear into the fog.
       this.updateMask_();
 
       this.classList.add('animating-tile-page');
       this.withinPageDrag_ = this.contains(currentlyDraggingTile);
       this.dragItemIndex_ = this.withinPageDrag_ ?
           currentlyDraggingTile.index : this.tileElements_.length;
       this.currentDropIndex_ = this.dragItemIndex_;
 
       // The new tile may change the number of rows, hence the top margin
@@ skipping 154 matching lines @@
       assert(false);
     },
   };
 
   return {
     getCurrentlyDraggingTile: getCurrentlyDraggingTile,
     setCurrentDropEffect: setCurrentDropEffect,
     TilePage: TilePage,
   };
 });