base/callback_internal.cc - Issue 10388060: Make Callback.Reset safe against deleting itself.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/callback_internal.cc

Issue 10388060: Make Callback.Reset safe against deleting itself. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review changes Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/callback_internal.cc

diff --git a/base/callback_internal.cc b/base/callback_internal.cc

index a483293257e445224c6c6148bc8e7c5a6ff2db58..65fe710a20c7ff25ae041d46c11fdb711277c2ff 100644

--- a/base/callback_internal.cc

+++ b/base/callback_internal.cc

@@ -14,8 +14,10 @@ bool CallbackBase::is_null() const {

}

void CallbackBase::Reset() {

- bind_state_ = NULL;

polymorphic_invoke_ = NULL;

+ // NULL the bind_state_ last, since it may be holding the last ref to whatever

+ // object owns us, and we may be deleted after that.

+ bind_state_ = NULL;

}

bool CallbackBase::Equals(const CallbackBase& other) const {

« no previous file with comments | « no previous file | base/callback_unittest.cc » ('j') | no next file with comments »