Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: ui/app_list/model_view_unittest.cc

Issue 10388032: Move app list from ash to ui. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: fix nits in #3 Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/model_view_unittest.cc
===================================================================
--- ui/app_list/model_view_unittest.cc (revision 0)
+++ ui/app_list/model_view_unittest.cc (working copy)
@@ -2,9 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "ash/app_list/app_list_item_view.h"
-#include "ash/app_list/app_list_model_view.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/app_list/app_list_item_view.h"
+#include "ui/app_list/app_list_model_view.h"
tfarina 2012/05/09 00:20:57 I think a more accurate name for this test file wo
xiyuan 2012/05/09 01:28:46 Done.
namespace {
@@ -18,12 +18,12 @@
} // namespace
-TEST(AppListTest, ModelViewCalculateLayout) {
+TEST(ModelViewTest, ModelViewCalculateLayout) {
// kMinTitleWidth is the average width of 15 chars of default size 12 font in
// chromeos. Override here to avoid flakiness from different default font on
// bots.
const int kMinTitleWidth = 90;
- ash::AppListItemView::SetMinTitleWidth(kMinTitleWidth);
+ app_list::AppListItemView::SetMinTitleWidth(kMinTitleWidth);
tfarina 2012/05/09 00:20:57 nit: you can wrap this unit test in app_list names
xiyuan 2012/05/09 01:28:46 Done.
const int kLauncherHeight = 50;
const ModelViewCalculateLayoutCase kCases[] = {
@@ -52,11 +52,11 @@
int cols = 0;
gfx::Size content_size(kCases[i].screen_size.width(),
kCases[i].screen_size.height() - kLauncherHeight);
- ash::AppListModelView::CalculateLayout(content_size,
- kCases[i].num_of_tiles,
- &icon_size,
- &rows,
- &cols);
+ app_list::AppListModelView::CalculateLayout(content_size,
+ kCases[i].num_of_tiles,
+ &icon_size,
+ &rows,
+ &cols);
EXPECT_EQ(kCases[i].expected_icon_size, icon_size) << "i=" << i;
EXPECT_EQ(kCases[i].expected_rows, rows) << "i=" << i;
EXPECT_EQ(kCases[i].expected_cols, cols) << "i=" << i;

Powered by Google App Engine
This is Rietveld 408576698