Pyauto Test to enable Nacl Sdk test and disable other nacl sdk test which no more exists.

Pyauto Test to disable all nacl sdk test which no more exists.

[Pooja Nihalani, 2012-05-07 20:26:53]

Pyauto test to enable Nacl Sdk test

[chrisphan, 2012-05-07 20:30:30]

http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS#newcod...
functional/PYAUTO_TESTS:496: 'nacl_sdk',
Can you remove this as well.  Add it back after you check in nacl_sdk.py

[dyu1, 2012-05-07 20:32:37]

Please get the approval from nirnimesh since he has full commit access. I don't
think getting our approval will allow you to commit this CL since we have
provisional commit access.

On 2012/05/07 20:30:30, chrisphan wrote:
> http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS
> File functional/PYAUTO_TESTS (right):
> 
>
http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS#newcod...
> functional/PYAUTO_TESTS:496: 'nacl_sdk',
> Can you remove this as well.  Add it back after you check in nacl_sdk.py

[Pooja Nihalani, 2012-05-07 20:59:02]

http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS#newcod...
functional/PYAUTO_TESTS:496: 'nacl_sdk',
On 2012/05/07 20:30:30, chrisphan wrote:
> Can you remove this as well.  Add it back after you check in nacl_sdk.py

Done.

[chrisphan, 2012-05-07 21:00:47]

On 2012/05/07 20:59:02, Pooja Nihalani wrote:
> http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS
> File functional/PYAUTO_TESTS (right):
> 
>
http://codereview.chromium.org/10388014/diff/1/functional/PYAUTO_TESTS#newcod...
> functional/PYAUTO_TESTS:496: 'nacl_sdk',
> On 2012/05/07 20:30:30, chrisphan wrote:
> > Can you remove this as well.  Add it back after you check in nacl_sdk.py
> 
> Done.

lgtm

[commit-bot: I haz the power, 2012-05-07 21:07:22]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Pooja Nihalani, 2012-05-07 21:11:37]

Hi Dennis,
I need to remove these old NaCl tests to enable the new one.
Thank you

[dennis_jeffrey, 2012-05-07 21:37:47]

One question.

http://codereview.chromium.org/10388014/diff/5001/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/10388014/diff/5001/functional/PYAUTO_TESTS#new...
functional/PYAUTO_TESTS:583: '-nacl_sdk',
Should we remove this too?

[Pooja Nihalani, 2012-05-07 21:48:42]

http://codereview.chromium.org/10388014/diff/5001/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/10388014/diff/5001/functional/PYAUTO_TESTS#new...
functional/PYAUTO_TESTS:583: '-nacl_sdk',
On 2012/05/07 21:37:47, dennis_jeffrey wrote:
> Should we remove this too?

Done.

[dennis_jeffrey, 2012-05-07 21:55:59]

LGTM

[commit-bot: I haz the power, 2012-05-07 21:58:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pnihalani@chromium.org/10388014/10001

[commit-bot: I haz the power, 2012-05-07 21:58:16]

Can't apply patch for file chrome/test/functional/PYAUTO_TESTS.
While running patch -p0 --forward --force;
patching file chrome/test/functional/PYAUTO_TESTS
Hunk #1 FAILED at 115.
Hunk #2 succeeded at 490 (offset -5 lines).
Hunk #3 succeeded at 576 (offset -5 lines).
1 out of 3 hunks FAILED -- saving rejects to file
chrome/test/functional/PYAUTO_TESTS.rej

[Nirnimesh, 2012-05-07 22:56:17]

The CL description says that you are enabling some tests. Where?

[Pooja Nihalani, 2012-05-07 23:04:15]

On 2012/05/07 22:56:17, Nirnimesh wrote:
> The CL description says that you are enabling some tests. Where?

I am disabling all the NaCl test here. I have edited the description.

[Nirnimesh, 2012-05-08 00:38:15]

http://codereview.chromium.org/10388014/diff/10001/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/10388014/diff/10001/functional/PYAUTO_TESTS#ol...
functional/PYAUTO_TESTS:498: 'nacl_sdk',
This will disable all nacl_sdk tests, not just the ones that don't exist.

[Pooja Nihalani, 2012-05-08 16:07:04]

http://codereview.chromium.org/10388014/diff/10001/functional/PYAUTO_TESTS
File functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/10388014/diff/10001/functional/PYAUTO_TESTS#ol...
functional/PYAUTO_TESTS:498: 'nacl_sdk',
Once I commit this,CL- http://codereview.chromium.org/10310047
will have PYAUTO_TESTS enable this nacl_sdk test.

On 2012/05/08 00:38:15, Nirnimesh wrote:
> This will disable all nacl_sdk tests, not just the ones that don't exist.

[Nirnimesh, 2012-05-08 17:18:41]

On 2012/05/08 16:07:04, Pooja Nihalani wrote:
> http://codereview.chromium.org/10388014/diff/10001/functional/PYAUTO_TESTS
> File functional/PYAUTO_TESTS (left):
> 
>
http://codereview.chromium.org/10388014/diff/10001/functional/PYAUTO_TESTS#ol...
> functional/PYAUTO_TESTS:498: 'nacl_sdk',
> Once I commit this,CL- http://codereview.chromium.org/10310047
> will have PYAUTO_TESTS enable this nacl_sdk test.
> 
> On 2012/05/08 00:38:15, Nirnimesh wrote:
> > This will disable all nacl_sdk tests, not just the ones that don't exist.

I don't understand the point of this CL. Worse still it doesn't match the
description (you're disabling all nacl_sdk tests but the description says that
you're deleting only the ones that do not exist). Why not do everything in
http://codereview.chromium.org/10310047/ where you seem to be touching the
PYAUTO_TESTS file too.