Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 10387232: Remove string concatenation with + from all Dart files in tools directory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index efdab52b718b4879cd53eb7763403f54bce9cca4..629937d0736556ea4bc7fd67496809ed7d057b65 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -545,7 +545,7 @@ class RunningProcess {
testCase.output.requestRetry = false;
this.timedOut = false;
testCase.dynamic.numRetries--;
- print("Potential flake. Re-running ${testCase.displayName} " +
+ print("Potential flake. Re-running ${testCase.displayName} "
"(${testCase.dynamic.numRetries} attempt(s) remains)");
this.start();
} else {
@@ -726,7 +726,7 @@ class BatchRunnerProcess {
}
String _createArgumentsLine(List<String> arguments) {
- return Strings.join(arguments, ' ') + '\n';
+ return Strings.join(arguments, ' ').concat('\n');
}
void _testCompleted() {
@@ -1037,7 +1037,7 @@ class ProcessQueue {
String filePath = new Options().script;
String pathSep = Platform.pathSeparator;
int index = filePath.lastIndexOf(pathSep);
- filePath = filePath.substring(0, index) + '${pathSep}testing${pathSep}';
+ filePath = '${filePath.substring(0, index)}${pathSep}testing${pathSep}';
var lister = new Directory(filePath).list();
lister.onFile = (String file) {
if (const RegExp(@"selenium-server-standalone-.*\.jar").hasMatch(file)
@@ -1095,11 +1095,11 @@ class ProcessQueue {
if (_numProcesses < _maxProcesses && !_tests.isEmpty()) {
TestCase test = _tests.removeFirst();
if (_listTests) {
- final String tab = '\t';
- String outcomes =
- Strings.join(new List.from(test.expectedOutcomes), ',');
- print(test.displayName + tab + outcomes + tab + test.isNegative +
- tab + Strings.join(test.commands.last().arguments, tab));
+ var fields = [test.displayName,
+ Strings.join(new List.from(test.expectedOutcomes), ','),
+ test.isNegative];
+ fields.addAll(test.commands.last().arguments);
+ print(Strings.join(fields, '\t'));
return;
}
if (test.usesWebDriver && _needsSelenium && !_isSeleniumAvailable) {

Powered by Google App Engine
This is Rietveld 408576698