Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: ipc/ipc_channel_posix_unittest.cc

Issue 10387218: Make GlobalDescriptors::MaybeGet return -1 when the key is not found. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Modifying the MULTIPROCESS_TEST_MAIN macro so it can be passed a setup method. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_channel_posix_unittest.cc
diff --git a/ipc/ipc_channel_posix_unittest.cc b/ipc/ipc_channel_posix_unittest.cc
index 834f0ea74487640e7a47f916fb384c08546ab456..127ac3b9f2bd99aff7dc5d688621f4f4559f792c 100644
--- a/ipc/ipc_channel_posix_unittest.cc
+++ b/ipc/ipc_channel_posix_unittest.cc
@@ -21,6 +21,7 @@
#include "base/test/multiprocess_test.h"
#include "base/test/test_timeouts.h"
#include "ipc/ipc_listener.h"
+#include "ipc/ipc_tests.h"
#include "testing/multiprocess_func_list.h"
namespace {
@@ -391,7 +392,8 @@ TEST_F(IPCChannelPosixTest, IsNamedServerInitialized) {
}
// A long running process that connects to us
-MULTIPROCESS_TEST_MAIN(IPCChannelPosixTestConnectionProc) {
+MULTIPROCESS_TEST_MAIN(IPCChannelPosixTestConnectionProc,
+ MultiProcessTestIPCSetUp) {
MessageLoopForIO message_loop;
IPCChannelPosixTestListener listener(true);
IPC::ChannelHandle handle(IPCChannelPosixTest::GetConnectionSocketName());
@@ -404,7 +406,8 @@ MULTIPROCESS_TEST_MAIN(IPCChannelPosixTestConnectionProc) {
}
// Simple external process that shouldn't be able to connect to us.
-MULTIPROCESS_TEST_MAIN(IPCChannelPosixFailConnectionProc) {
+MULTIPROCESS_TEST_MAIN(IPCChannelPosixFailConnectionProc,
jeremy 2012/06/13 19:25:55 Can you define a version of this Macro that define
Jay Civelli 2012/06/13 20:40:49 Good idea, done.
+ MultiProcessTestIPCSetUp) {
MessageLoopForIO message_loop;
IPCChannelPosixTestListener listener(false);
IPC::ChannelHandle handle(IPCChannelPosixTest::GetConnectionSocketName());

Powered by Google App Engine
This is Rietveld 408576698