chrome/browser/importer/firefox_importer_unittest_utils_mac.cc - Issue 10387218: Make GlobalDescriptors::MaybeGet return -1 when the key is not found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

Issue 10387218: Make GlobalDescriptors::MaybeGet return -1 when the key is not found. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Modifying the MULTIPROCESS_TEST_MAIN macro so it can be passed a setup method. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

diff --git a/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc b/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

index d609cc96e539b487bca9685851ae54836381291e..c4ac0a2094118b1704147d3947774aeea4664e34 100644

--- a/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

+++ b/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

@@ -9,6 +9,7 @@

#include "base/command_line.h"

#include "base/file_path.h"

#include "base/file_util.h"

+#include "base/global_descriptors_posix.h"

#include "base/message_loop.h"

#include "base/test/test_timeouts.h"

#include "chrome/browser/importer/firefox_importer_utils.h"

@@ -16,6 +17,7 @@

#include "ipc/ipc_descriptors.h"

#include "ipc/ipc_message.h"

#include "ipc/ipc_switches.h"

+#include "ipc/ipc_tests.h"

#include "testing/multiprocess_func_list.h"

#define IPC_MESSAGE_IMPL

@@ -263,7 +265,7 @@ class FFDecryptorClientChannelListener : public IPC::Channel::Listener {

};

// Entry function in child process.

-MULTIPROCESS_TEST_MAIN(NSSDecrypterChildProcess) {

+MULTIPROCESS_TEST_MAIN(NSSDecrypterChildProcess, MultiProcessTestIPCSetUp) {

MessageLoopForIO main_message_loop;

FFDecryptorClientChannelListener listener;