Suppress pause-and-buffer behavior when the HTTP response won't satisfy future requests via cache.

net/http/http_response_headers.cc

Index: net/http/http_response_headers.cc
diff --git a/net/http/http_response_headers.cc b/net/http/http_response_headers.cc
index 33d78dad0dee6ed21f634baa6fdc2b32ba9d4825..ea7019d2bd115e0bd2de25bc185d0425e9afb42b 100644
--- a/net/http/http_response_headers.cc
+++ b/net/http/http_response_headers.cc
@@ -1160,32 +1160,14 @@ bool HttpResponseHeaders::IsKeepAlive() const {
 }
 
 bool HttpResponseHeaders::HasStrongValidators() const {
-  if (GetHttpVersion() < HttpVersion(1, 1))
-    return false;
-
-  std::string etag_value;
-  EnumerateHeader(NULL, "etag", &etag_value);
-  if (!etag_value.empty()) {
-    size_t slash = etag_value.find('/');
-    if (slash == std::string::npos || slash == 0)
-      return true;
-
-    std::string::const_iterator i = etag_value.begin();
-    std::string::const_iterator j = etag_value.begin() + slash;
-    HttpUtil::TrimLWS(&i, &j);
-    if (!LowerCaseEqualsASCII(i, j, "w"))
-      return true;
-  }
-
-  Time last_modified;
-  if (!GetLastModifiedValue(&last_modified))
-    return false;
-
-  Time date;
-  if (!GetDateValue(&date))
-    return false;
-
-  return ((date - last_modified).InSeconds() >= 60);
+  std::string etag_header;
+  EnumerateHeader(NULL, "etag", &etag_header);
+  std::string last_modified_header;
+  EnumerateHeader(NULL, "Last-Modified", &last_modified_header);

[scherkus (not reviewing), 2012/05/23 01:16:03]

FYI I notice a lot of lower-case headers in this file

[Ami GONE FROM CHROMIUM, 2012/05/23 01:27:28]

Elected to stay consistent with existing capitalization in this file.

[scherkus (not reviewing), 2012/05/23 01:34:19]

Yeah nevermind -- the stuff at the top of this file is all lowercase but the
stuff nearer the bottom is capitalized

Oh well.

+  std::string date_header;
+  EnumerateHeader(NULL, "Date", &last_modified_header);
+  return HttpUtil::HasStrongValidators(
+      GetHttpVersion(), etag_header, last_modified_header, date_header);

[rvargas (doing something else), 2012/05/23 02:04:12]

nit: this call should start enumerating arguments on the previous line.

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

That'd require ASCII art and more vertical space than this way (see comment
elsewhere).

[rvargas (doing something else), 2012/05/23 18:26:09]

Just look at the Google style guide.

 }
 
 // From RFC 2616: