Suppress pause-and-buffer behavior when the HTTP response won't satisfy future requests via cache.

webkit/media/cache_util_unittest.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/media/cache_util.h"
+
+#include <string>
+
+#include "base/stringprintf.h"
+#include "base/string_number_conversions.h"
+#include "base/string_util.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLResponse.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using WebKit::WebString;
+using WebKit::WebURLResponse;
+
+namespace webkit_media {
+
+struct GTFUTestCase {

[scherkus (not reviewing), 2012/05/23 01:16:03]

does GTFU mean "Get Treasons For Uncacheability"?

[Ami GONE FROM CHROMIUM, 2012/05/23 01:27:28]

s/Treasons/Reasons/
Yes.

[rvargas (doing something else), 2012/05/23 02:04:12]

?

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

Oops, renamed & doco'd.

+  WebURLResponse::HTTPVersion version;
+  int status_code;
+  const char* headers;
+  const char* expected_reasons;
+};
+
+// Create a new WebURLResponse object.
+static WebURLResponse CreateResponse(const GTFUTestCase& test) {
+  WebURLResponse response;
+  response.initialize();
+  response.setHTTPVersion(test.version);
+  response.setHTTPStatusCode(test.status_code);
+  std::vector<std::string> lines;
+  Tokenize(test.headers, "\n", &lines);
+  for (size_t i = 0; i < lines.size(); ++i) {
+    size_t colon = lines[i].find(": ");
+    response.addHTTPHeaderField(
+        WebString::fromUTF8(lines[i].substr(0, colon)),
+        WebString::fromUTF8(lines[i].substr(colon + 2)));
+  }
+  return response;
+}
+
+TEST(CacheUtilTest, GetReasonsForUncacheability) {
+  const GTFUTestCase tests[] = {
+    {
+      WebURLResponse::HTTP_1_1, 206, "ETag: 'fooblort'", ""
+    },
+    {
+      WebURLResponse::HTTP_1_1, 206, "", "3"
+    },
+    {
+      WebURLResponse::HTTP_1_0, 206, "", "2,3"
+    },
+    {
+      WebURLResponse::HTTP_1_1, 200, "cache-control: max-age=42", "4"
+    },
+    {
+      WebURLResponse::HTTP_1_1, 200,
+      "Date: Tue, 22 May 2012 23:46:08 GMT\n"
+      "Expires: Tue, 22 May 2012 23:56:08 GMT", "5"
+    },
+    {
+      WebURLResponse::HTTP_1_1, 200, "cache-control: must-revalidate", "6"
+    },
+    {
+      WebURLResponse::HTTP_1_1, 200, "cache-control: no-cache", "7"
+    },
+    {
+      WebURLResponse::HTTP_1_1, 200, "cache-control: no-store", "8"
+    },
+    {
+      WebURLResponse::HTTP_1_1, 200,
+      "cache-control: no-cache\ncache-control: no-store", "7,8"
+    },
+  };
+  for (size_t i = 0; i < arraysize(tests); ++i) {
+    SCOPED_TRACE(StringPrintf("case: %zu, version: %d, code: %d, headers: %s",
+                              i, tests[i].version, tests[i].status_code,
+                              tests[i].headers));
+    std::vector<UncacheableReason> reasons =
+        GetReasonsForUncacheability(CreateResponse(tests[i]));
+    std::string reasons_str;
+    for (size_t r = 0; r < reasons.size(); ++r) {
+      reasons_str.append(base::IntToString(reasons[r]));
+      if (r + 1 < reasons.size())
+        reasons_str.append(",");
+    }
+    EXPECT_EQ(tests[i].expected_reasons, reasons_str);
+  }
+}
+
+}  // namespace webkit_media