Suppress pause-and-buffer behavior when the HTTP response won't satisfy future requests via cache.

webkit/media/cache_util.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "webkit/media/cache_util.h"
+
+#include <string>
+
+#include "base/string_number_conversions.h"
+#include "base/string_util.h"
+#include "base/time.h"
+#include "net/http/http_util.h"
+#include "net/http/http_version.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCString.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLResponse.h"
+
+using base::Time;
+using base::TimeDelta;
+using net::HttpVersion;
+using WebKit::WebURLResponse;
+
+namespace webkit_media {
+
+enum { kHttpOK = 200, kHttpPartialContent = 206 };

[rvargas (doing something else), 2012/05/23 02:04:12]

nit: enums are supposed to be upper case.

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

Yeah... This is a place where chromium's style guide conflicts w/ google style
guide (which points out that MACRO_STYLE is likely to conflict with macros). 
media/ code goes w/ the kStyle in >90% of locations so I'm inclined to apply the
consistency defense here.

+
+std::vector<UncacheableReason> GetReasonsForUncacheability(
+    const WebURLResponse& response) {
+  std::vector<UncacheableReason> reasons;
+  const int code = response.httpStatusCode();
+  const int version = response.httpVersion();
+  const HttpVersion http_version =
+      version == WebURLResponse::HTTP_1_1 ? HttpVersion(1, 1) :
+      version == WebURLResponse::HTTP_1_0 ? HttpVersion(1, 0) :
+      version == WebURLResponse::HTTP_0_9 ? HttpVersion(0, 9) :
+      HttpVersion();
+  if (code != kHttpOK && code != kHttpPartialContent)
+    reasons.push_back(kNoData);
+  if (http_version < HttpVersion(1, 1) && code == kHttpPartialContent)
+    reasons.push_back(kPre11PartialResponse);
+  if (code == kHttpPartialContent && !net::HttpUtil::HasStrongValidators(

[rvargas (doing something else), 2012/05/23 02:04:12]

nit: could you break this at the &&

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

Done, though I don't think it helps...

+          http_version,
+          response.httpHeaderField("etag").utf8(),
+          response.httpHeaderField("Last-Modified").utf8(),

[scherkus (not reviewing), 2012/05/23 01:16:03]

minor ocd nit again: I wonder if we should be consistent w/ casing

[Ami GONE FROM CHROMIUM, 2012/05/23 01:27:28]

rfc2616 4.2: header names are case-insensitive (which the code accounts for).  
I went for consistency w/ http_response_headers.cc.

+          response.httpHeaderField("Date").utf8())) {
+    reasons.push_back(kNoStrongValidatorOnPartialResponse);
+  }
+
+  std::string cache_control_header =
+      response.httpHeaderField("cache-control").utf8();
+  StringToLowerASCII(&cache_control_header);
+  if (cache_control_header.find("no-cache") != std::string::npos)
+    reasons.push_back(kNoCache);
+  if (cache_control_header.find("no-store") != std::string::npos)
+    reasons.push_back(kNoStore);
+  if (cache_control_header.find("must-revalidate") != std::string::npos)
+    reasons.push_back(kHasMustRevalidate);
+
+  const TimeDelta kMinimumAgeForUsefulness =
+      TimeDelta::FromSeconds(3600);  // Arbitrary value.
+
+  const char kMaxAgePrefix[] = "max-age=";
+  const size_t kMaxAgePrefixLen = arraysize(kMaxAgePrefix) - 1;
+  if (LowerCaseEqualsASCII(
+          cache_control_header.begin(),

[rvargas (doing something else), 2012/05/23 02:04:12]

nit: prev line

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

Nope :)

+          cache_control_header.begin() + kMaxAgePrefixLen,
+          kMaxAgePrefix)) {
+    int64 max_age_seconds;
+    base::StringToInt64(
+        base::StringPiece(
+            cache_control_header.begin() + kMaxAgePrefixLen,

[rvargas (doing something else), 2012/05/23 02:04:12]

nit:prev line

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

Ditto.

+            cache_control_header.end()),
+        &max_age_seconds);
+    if (TimeDelta::FromSeconds(max_age_seconds) < kMinimumAgeForUsefulness)
+      reasons.push_back(kShortMaxAge);
+  }
+
+  Time date;
+  Time expires;
+  if (Time::FromString(response.httpHeaderField("Date").utf8().data(), &date) &&
+      Time::FromString(
+          response.httpHeaderField("Expires").utf8().data(), &expires) &&

[rvargas (doing something else), 2012/05/23 02:04:12]

nit: I'd also move the first arg to the previousline

[Ami GONE FROM CHROMIUM, 2012/05/23 03:55:23]

Ditto.

+      date > Time() && expires > Time() &&
+      (expires - date) < kMinimumAgeForUsefulness) {
+    reasons.push_back(kExpiresTooSoon);
+  }
+
+  return reasons;
+}
+
+}  // namespace webkit_media