Pepper Flash settings integration: add UI for "deauthorize content licenses".

chrome/browser/plugin_data_remover_helper.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_
 #define CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_
 #pragma once
 
-#include <vector>
+#include <string>
 
-#include "base/memory/ref_counted.h"
-#include "base/memory/weak_ptr.h"
-#include "chrome/browser/prefs/pref_member.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "chrome/browser/plugin_status_pref_setter.h"
 
 class PluginPrefs;
-class Profile;
 
-namespace webkit {
-struct WebPluginInfo;
-}
-
-// Helper class modeled after BooleanPrefMember to (asynchronously) update
-// the preference specifying whether clearing plug-in data is supported
-// by an installed plug-in.
-// It should only be used from the UI thread. The client has to make sure that
-// the passed profile outlives this object.
-class PluginDataRemoverHelper : public content::NotificationObserver {
+// Helper class to (asynchronously) update the preference specifying whether

[brettw, 2012/05/20 21:15:40]

I don't get the point of this class, and I don't see anything asynchronous in
it.

[yzshen1, 2012/05/21 16:58:44]

The 'async' part is moved into PluginStatusPrefSetter, which set several pref
values specified by PluginStatusPrefSetter::Client.

Do you think it is better to merge the two clients directly into
PluginStatusPrefSetter? (But we may want to keep the static IsSupported() here.)
Or do you suggest me to update the comments?

Thanks!
On 2012/05/20 21:15:40, brettw wrote:

+// clearing plug-in data is supported by an installed plug-in.
+class PluginDataRemoverHelper : public PluginStatusPrefSetter::Client {
  public:
-  PluginDataRemoverHelper();
+  explicit PluginDataRemoverHelper(const char* pref_name);
   virtual ~PluginDataRemoverHelper();
 
-  // Binds this object to the |pref_name| preference in the profile's
-  // PrefService, notifying |observer| if the value changes.
-  // This asynchronously calls the PluginService to get the list of installed
-  // plug-ins.
-  void Init(const char* pref_name,
-            Profile* profile,
-            content::NotificationObserver* observer);
-
-  bool GetValue() const { return pref_.GetValue(); }
-
   // Like PluginDataRemover::IsSupported, but checks that the returned plugin
-  // is enabled by PluginPrefs
+  // is enabled by PluginPrefs.
   static bool IsSupported(PluginPrefs* plugin_prefs);
 
-  // content::NotificationObserver methods:
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) OVERRIDE;
+  // PluginStatusPrefSetter::Client implementation.
+  virtual const char* GetPrefName() const OVERRIDE;
+  virtual bool CalculatePrefValue(PluginPrefs* plugin_prefs) OVERRIDE;
 
  private:
-  void StartUpdate();
-  void GotPlugins(scoped_refptr<PluginPrefs> plugin_prefs,
-                  const std::vector<webkit::WebPluginInfo>& plugins);
-
-  BooleanPrefMember pref_;
-  content::NotificationRegistrar registrar_;
-  // Weak pointer.
-  Profile* profile_;
-  base::WeakPtrFactory<PluginDataRemoverHelper> factory_;
+  std::string pref_name_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginDataRemoverHelper);
 };
 
 #endif  // CHROME_BROWSER_PLUGIN_DATA_REMOVER_HELPER_H_