Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/sync/glue/data_type_manager.h

Issue 10387144: [Sync] - Implement isolated model association. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: For review. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/data_type_manager.h
diff --git a/chrome/browser/sync/glue/data_type_manager.h b/chrome/browser/sync/glue/data_type_manager.h
index 7dc7f15402e6bc63778538bdea5068ad8f2413f7..87f7f00df20eca02ebe882dc1f352581b0266218 100644
--- a/chrome/browser/sync/glue/data_type_manager.h
+++ b/chrome/browser/sync/glue/data_type_manager.h
@@ -60,11 +60,21 @@ class DataTypeManager {
TypeSet requested_types);
ConfigureResult(ConfigureStatus status,
TypeSet requested_types,
- const std::list<SyncError>& errors);
+ const std::list<SyncError>& failed_data_types,
+ syncable::ModelTypeSet waiting_to_start);
~ConfigureResult();
ConfigureStatus status;
TypeSet requested_types;
- std::list<SyncError> errors;
+
+ // These types encountered a failure in association.
+ std::list<SyncError> failed_data_types;
+
+ // These types are waiting to start associating. Since we have
+ // waited long enough we have exited out of the configure cycle.
+ // However these types could still be loading on the backend.
+ // However they will not start associating unless we are in a configure
+ // cycle.
tim (not reviewing) 2012/05/21 23:18:57 Wording is a bit unclear, perhaps "List of types t
lipalani1 2012/05/22 01:23:58 Done.
+ syncable::ModelTypeSet waiting_to_start;
};
virtual ~DataTypeManager() {}

Powered by Google App Engine
This is Rietveld 408576698