[Sync] - Implement isolated model association.

chrome/browser/sync/glue/data_type_manager_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/data_type_manager_impl.h"
 
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
 #include "chrome/browser/sync/glue/backend_data_type_configurer.h"
 #include "chrome/browser/sync/glue/data_type_controller.h"
 #include "chrome/browser/sync/glue/fake_data_type_controller.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/test/notification_observer_mock.h"
 #include "content/test/test_browser_thread.h"
 #include "sync/internal_api/configure_reason.h"
 #include "sync/syncable/model_type.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace browser_sync {
 
 using syncable::ModelType;
 using syncable::ModelTypeSet;
 using syncable::ModelTypeToString;
 using syncable::BOOKMARKS;
+using syncable::APPS;
 using syncable::PASSWORDS;
 using syncable::PREFERENCES;
 using testing::_;
 using testing::Mock;
 using testing::ResultOf;
 
 // Fake BackendDataTypeConfigurer implementation that simply stores
 // away the nigori state and callback passed into ConfigureDataTypes.
 class FakeBackendDataTypeConfigurer : public BackendDataTypeConfigurer {
  public:
@@ skipping 156 matching lines @@
   FinishDownload(dtm, ModelTypeSet());
   EXPECT_EQ(DataTypeManager::CONFIGURING, dtm.state());
 
   GetController(BOOKMARKS)->FinishStart(DataTypeController::OK);
   EXPECT_EQ(DataTypeManager::CONFIGURED, dtm.state());
 
   dtm.Stop();
   EXPECT_EQ(DataTypeManager::STOPPED, dtm.state());
 }
 
+// Set up a DTM with 2 controllers. configure it. One of them finishes loading
+// after the  timeout. Make sure eventually all are configured.
+TEST_P(SyncDataTypeManagerImplTest, ConfigureSlowLoadingType) {
+  AddController(BOOKMARKS);
+  AddController(APPS);
+
+  GetController(BOOKMARKS)->SetDelayModelLoad();
+
+  DataTypeManagerImpl dtm(&configurer_, &controllers_);
+  SetConfigureStartExpectation();
+  SetConfigureDoneExpectation(DataTypeManager::PARTIAL_SUCCESS);
+
+  syncable::ModelTypeSet types;
+  types.Put(BOOKMARKS);
+  types.Put(APPS);
+
+  Configure(&dtm, types);
+  EXPECT_EQ(DataTypeManager::DOWNLOAD_PENDING, dtm.state());
+
+  FinishDownload(dtm, ModelTypeSet());
+  EXPECT_EQ(DataTypeManager::CONFIGURING, dtm.state());
+
+  base::OneShotTimer<ModelAssociationManager>* timer =
+    dtm.GetModelAssociationManagerForTesting()->GetTimerForTesting();
+
+  base::Closure task = timer->user_task();
+  timer->Stop();
+  task.Run();
+
+  SetConfigureDoneExpectation(DataTypeManager::OK);
+  GetController(APPS)->FinishStart(DataTypeController::OK);
+
+  SetConfigureStartExpectation();
+  GetController(BOOKMARKS)->FinishModelLoad();
+
+  FinishDownload(dtm, ModelTypeSet());
+  GetController(BOOKMARKS)->FinishModelLoad();
+
+  GetController(BOOKMARKS)->FinishStart(DataTypeController::OK);
+  EXPECT_EQ(DataTypeManager::CONFIGURED, dtm.state());
+
+  dtm.Stop();
+  EXPECT_EQ(DataTypeManager::STOPPED, dtm.state());
+}
+
+
 // Set up a DTM with a single controller, configure it, but stop it
 // before finishing the download.  It should still be safe to run the
 // download callback even after the DTM is stopped and destroyed.
 TEST_P(SyncDataTypeManagerImplTest, ConfigureOneStopWhileDownloadPending) {
   AddController(BOOKMARKS);
 
   {
     DataTypeManagerImpl dtm(&configurer_, &controllers_);
     SetConfigureStartExpectation();
     SetConfigureDoneExpectation(DataTypeManager::ABORTED);
@@ skipping 456 matching lines @@
 
 INSTANTIATE_TEST_CASE_P(
     WithoutNigori, SyncDataTypeManagerImplTest,
     ::testing::Values(BackendDataTypeConfigurer::WITHOUT_NIGORI));
 
 INSTANTIATE_TEST_CASE_P(
     WithNigori, SyncDataTypeManagerImplTest,
     ::testing::Values(BackendDataTypeConfigurer::WITH_NIGORI));
 
 }  // namespace browser_sync