Copy VS CRT DLLs in output directory before packaging component builds.

Copy VS CRT DLLs in output directory before packaging component builds.

This ensures we don't get "missing crt dlls" errors when copying setup.exe to another machine.

It also ensures the CRT dlls are packaged by create_installer_archive.py and marked as dependencies of chrome.exe and setup.exe.

BUG=127233
TEST=Copy setup.exe, setup.exe.manifest, chrome.packed.7z, and *.dll from the build output directory to another machine and run setup.exe there. Confirm that it's able to install at that the installed chrome.exe and setup.exe function properly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137807

[gab, 2012-05-15 22:08:29]

Robert can you take a quick look?

As discussed, this not ideal as it hardcodes the path only for VS2010... but
it's better than nothing and doesn't break anything on prior VSes (it simply
doesn't fix when never worked...). If anyone wants this to work on prior VSes we
can think of a broader solution later; but for now, this does the job.

The reason I did it in python rather than as a copy rule in gyp is that python
here allows me to glob to grab any DLL version that might be present as opposed
to a specific one.

FYI, for me specifically the DLLs are:
C:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\redist\x86\Microsoft.VC100.CRT\msvcp100.dll\
C:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\redist\x86\Microsoft.VC100.CRT\msvcr100.dll

And for debug builds it's:
C:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\redist\Debug_NonRedist\x86\Microsoft.VC100.DebugCRT\msvcp100d.dll
C:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\redist\Debug_NonRedist\x86\Microsoft.VC100.DebugCRT\msvscr100d.dll

Thanks,
Gab

[gab, 2012-05-15 23:02:18]

One little nit addressed, see below.

https://chromiumcodereview.appspot.com/10387140/diff/3001/chrome/tools/build/...
File chrome/tools/build/win/create_installer_archive.py (right):

https://chromiumcodereview.appspot.com/10387140/diff/3001/chrome/tools/build/...
chrome/tools/build/win/create_installer_archive.py:531: elif not
options.build_dir.endswith('/'):
The way create_installer_archive is currently being called the Debug path ends
with a '/' in the Debug build and not the Release path in the Release build...
uniforming the incoming parameter to make the new check above more consistent.

[gab, 2012-05-16 06:58:38]

This patch is now written on top of
https://chromiumcodereview.appspot.com/10399041/

I'm not sure what the side effects of laying down CRT DLLs in the build output
directory can be, but Robert told me it was fine earlier today.

I made this very general, copying more than necessary to avoid complicated logic
to figure out what's needed. I don't think this is a problem given the CRT DLLs
are fairly lightweight compared to the rest of the DLLs and the archive anyways
and that they are independent (i.e. chrome.exe will only use the ones it
actually needs at run-time).

I put up a sample build output from this CL and the one it depends on at:
https://docs.google.com/a/google.com/open?id=0B_got0batQ0Ta01wN1I1ZXNtRDg
for your analysis pleasure :)!

Cheers,
Gab

[robertshield, 2012-05-17 16:36:53]

lgtm

[commit-bot: I haz the power, 2012-05-18 01:48:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gab@chromium.org/10387140/8001

[commit-bot: I haz the power, 2012-05-18 03:03:08]

Change committed as 137807