Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1592)

Unified Diff: build/android/buildbot_functions.sh

Issue 10387086: Run APK tests on the android_test trybot. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/buildbot_functions.sh
diff --git a/build/android/buildbot_functions.sh b/build/android/buildbot_functions.sh
index 2ea50f396be91a6be873e84564205a5b10480caf..4e6fa592e030eccdd0ea77f687c7aae0af709590 100755
--- a/build/android/buildbot_functions.sh
+++ b/build/android/buildbot_functions.sh
@@ -194,23 +194,12 @@ function bb_compile {
# Re-gyp and compile with unit test bundles configured as shlibs for
# the native test runner. Experimental for now. Once the native test
# loader is on by default, this entire function becomes obsolete.
-function bb_native_test_compile_run_tests {
+function bb_apk_test_compile {
echo "@@@BUILD_STEP Re-gyp for the native test runner@@@"
GYP_DEFINES="$GYP_DEFINES gtest_target_type=shared_library" android_gyp
echo "@@@BUILD_STEP Native test runner compile@@@"
bb_goma_make
-
- # Make sure running the template prints an expected failure.
- echo "@@@BUILD_STEP Native test runner template test@@@"
- tempfile=/tmp/tempfile-$$.txt
- build/android/run_tests.py --xvfb --verbose \
- -s out/Release/replaceme_apk/replaceme-debug.apk \
- | sed 's/@@@STEP_FAILURE@@@//g' | tee $tempfile
- happy_failure=$(cat $tempfile | grep RUNNER_FAILED | wc -l)
- if [[ $happy_failure -eq 0 ]] ; then
- echo "@@@STEP_WARNINGS@@@"
- fi
}
# Experimental compile step; does not turn the tree red if it fails.
@@ -239,3 +228,17 @@ function bb_run_tests {
echo "@@@BUILD_STEP Run Tests on actual hardware@@@"
build/android/run_tests.py --xvfb --verbose
}
+
+# Run APK tests on an actual device.
+function bb_run_apk_tests {
John Grabowski 2012/05/15 23:50:28 how about apk_test_run to be consistewnt
nilesh 2012/05/16 00:02:05 Done.
+ echo "@@@BUILD_STEP Run APK Tests on actual hardware@@@"
+ tempfile=/tmp/tempfile-$$.txt
+ # Filter out STEP_FAILURES, we don't want REDNESS on test failures for now.
+ build/android/run_tests.py --xvfb --verbose --apk=True \
+ | sed 's/@@@STEP_FAILURE@@@//g' | tee $tempfile
+ happy_failure=$(cat $tempfile | grep RUNNER_FAILED | wc -l)
+ if [[ $happy_failure -eq 0 ]] ; then
+ echo "@@@STEP_WARNINGS@@@"
+ fi
+ rm -f $tempfile
+}

Powered by Google App Engine
This is Rietveld 408576698