Run APK tests on the android_test trybot.

build/android/buildbot_functions.sh

 #!/bin/bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # Bash functions used by buildbot annotator scripts for the android
 # build of chromium.  Executing this script should not perform actions
 # other than setting variables and defining of functions.
 
 # Number of jobs on the compile line; e.g.  make -j"${JOBS}"
@@ skipping 176 matching lines @@
 function bb_compile {
   # This must be named 'compile', not 'Compile', for CQ interaction.
   # Talk to maruel for details.
   echo "@@@BUILD_STEP compile@@@"
   bb_goma_make
 }
 
 # Re-gyp and compile with unit test bundles configured as shlibs for
 # the native test runner.  Experimental for now.  Once the native test
 # loader is on by default, this entire function becomes obsolete.
 function bb_native_test_compile_run_tests {

[Yaron, 2012/05/15 01:57:38]

What happens with this?

[nilesh, 2012/05/15 02:29:18]

We still need this step.

   echo "@@@BUILD_STEP Re-gyp for the native test runner@@@"
   GYP_DEFINES="$GYP_DEFINES gtest_target_type=shared_library" android_gyp
 
   echo "@@@BUILD_STEP Native test runner compile@@@"
   bb_goma_make
 
   # Make sure running the template prints an expected failure.
   echo "@@@BUILD_STEP Native test runner template test@@@"
   tempfile=/tmp/tempfile-$$.txt
   build/android/run_tests.py --xvfb --verbose \
     -s out/Release/replaceme_apk/replaceme-debug.apk \
     | sed 's/@@@STEP_FAILURE@@@//g' | tee $tempfile
   happy_failure=$(cat $tempfile | grep RUNNER_FAILED | wc -l)
   if [[ $happy_failure -eq 0 ]] ; then
     echo "@@@STEP_WARNINGS@@@"

[John Grabowski, 2012/05/15 22:24:39]

looks like this is missing a "rm -f $tempfile"
can you add it?

[nilesh, 2012/05/15 22:59:25]

Done.

   fi
 }
 
 # Experimental compile step; does not turn the tree red if it fails.
 function bb_compile_experimental {
   # Linking DumpRenderTree appears to hang forever?
   EXPERIMENTAL_TARGETS="android_experimental"
   for target in ${EXPERIMENTAL_TARGETS} ; do
     echo "@@@BUILD_STEP Experimental Compile $target @@@"
     set +e
     bb_goma_make -k "${target}"
     if [ $? -ne 0 ] ; then
       echo "@@@STEP_WARNINGS@@@"
     fi
     set -e
   done
 }
 
 # Run tests on an emulator.
 function bb_run_tests_emulator {
   echo "@@@BUILD_STEP Run Tests on an Emulator@@@"
   build/android/run_tests.py -e --xvfb --verbose
 }
 
 # Run tests on an actual device.  (Better have one plugged in!)
 function bb_run_tests {
   echo "@@@BUILD_STEP Run Tests on actual hardware@@@"
   build/android/run_tests.py --xvfb --verbose
 }
+
+# Run APK tests on an actual device.
+function bb_run_apk_tests {
+  echo "@@@BUILD_STEP Run APK Tests on actual hardware@@@"
+  tempfile=/tmp/tempfile-$$.txt
+  # Filter out STEP_FAILURES, we don't want REDNESS on test failures for now.
+  build/android/run_tests.py --xvfb --verbose --apk=True \
+    | sed 's/@@@STEP_FAILURE@@@//g' | tee $tempfile
+  happy_failure=$(cat $tempfile | grep RUNNER_FAILED | wc -l)
+  if [[ $happy_failure -eq 0 ]] ; then
+    echo "@@@STEP_WARNINGS@@@"
+  fi

[John Grabowski, 2012/05/15 22:24:39]

rm -f $tempfile
but...

refactor so we have a bb_run_tests_internal that takes an arg and is used by
both bb_run_apk_tests and bb_blah...

[nilesh, 2012/05/15 22:59:25]

I have not removed the run_tests.py step from bb_native_test_compile_run_tests
I am now running replaceme-debug.apk as part of running the test bundles.

[John Grabowski, 2012/05/15 23:06:31]

Yes.  What I meant was, you did some cut and paste then changed 12 chars (added
--apk=True).  Instead, create a new function that takes an arg.  Call that new
function from both here and from the original test function.  Avoid dup.

+}

[John Grabowski, 2012/05/15 22:24:39]

delete $tempfile when done

[nilesh, 2012/05/15 22:59:25]

Done.