content/renderer/render_view_impl.h - Issue 10387074: Only disallow top-level navigations in platform apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 10387074: Only disallow top-level navigations in platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Skip test Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index fc77452a7ee3333b7bb8360bb05d07778dae55e9..a5bc27afdd5d855df7466fa03a3666ad39a1785b 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -993,11 +993,6 @@ class RenderViewImpl : public RenderWidget,

bool IsBackForwardToStaleEntry(const ViewMsg_Navigate_Params& params,

bool is_reload);

- // Returns false unless this is a top-level navigation that crosses origins.

- bool IsNonLocalTopLevelNavigation(const GURL& url,

- WebKit::WebFrame* frame,

- WebKit::WebNavigationType type);

bool MaybeLoadAlternateErrorPage(WebKit::WebFrame* frame,

const WebKit::WebURLError& error,

bool replace);