chrome/browser/ui/extensions/shell_window.cc - Issue 10387074: Only disallow top-level navigations in platform apps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10387074: Only disallow top-level navigations in platform apps (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Mike's review feedback Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/shell_window.cc

diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc

index 0371ab79eab00a4c575f9a1573a186b45c39b464..da708e2124f6238138bd91f51df50b8847d69cc3 100644

--- a/chrome/browser/ui/extensions/shell_window.cc

+++ b/chrome/browser/ui/extensions/shell_window.cc

@@ -98,8 +98,8 @@ ShellWindow::ShellWindow(Profile* profile,

content::WebContentsObserver::Observe(web_contents_.get());

web_contents_->SetDelegate(this);

web_contents_->SetViewType(chrome::VIEW_TYPE_APP_SHELL);

- web_contents_->GetMutableRendererPrefs()->browser_handles_all_requests =

- true;

+ web_contents_->GetMutableRendererPrefs()->

+ browser_handles_all_top_level_or_non_local_requests = true;

web_contents_->GetRenderViewHost()->SyncRendererPrefs();

web_contents_->GetController().LoadURL(