Let WeakPtrFactory operations fail once its dtor is called

base/memory/weak_ptr.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Weak pointers help in cases where you have many objects referring back to a
 // shared object and you wish for the lifetime of the shared object to not be
 // bound to the lifetime of the referrers.  In other words, this is useful when
 // reference counting is not a good fit.
 //
 // Thread-safety notes:
@@ skipping 213 matching lines @@
 // A class may alternatively be composed of a WeakPtrFactory and thereby
 // control how it exposes weak pointers to itself.  This is helpful if you only
 // need weak pointers within the implementation of a class.  This class is also
 // useful when working with primitive types.  For example, you could have a
 // WeakPtrFactory<bool> that is used to pass around a weak reference to a bool.
 template <class T>
 class WeakPtrFactory {
  public:
   explicit WeakPtrFactory(T* ptr) : ptr_(ptr) {
   }
+  ~WeakPtrFactory(){

[darin (slow to review), 2012/05/17 22:00:52]

nit: add new line above the destructor

[oshima, 2012/05/17 22:16:43]

Done.

+    ptr_ = NULL;

[darin (slow to review), 2012/05/17 22:00:52]

i wonder... should we null this out only in debug builds?

[oshima, 2012/05/17 22:16:43]

I wanted this to fail on trybots, which is release build but
dcheck enabled. How about this then?

#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)

+  }
 
   WeakPtr<T> GetWeakPtr() {
+    DCHECK(ptr_);
     return WeakPtr<T>(weak_reference_owner_.GetRef(), ptr_);
   }
 
   // Call this method to invalidate all existing weak pointers.
   void InvalidateWeakPtrs() {
+    DCHECK(ptr_);
     weak_reference_owner_.Invalidate();
   }
 
   // Call this method to determine if any weak pointers exist.
   bool HasWeakPtrs() const {
+    DCHECK(ptr_);
     return weak_reference_owner_.HasRefs();
   }
 
   // Indicates that this object will be used on another thread from now on.
   void DetachFromThread() {
+    DCHECK(ptr_);
     weak_reference_owner_.DetachFromThread();
   }
 
  private:
   internal::WeakReferenceOwner weak_reference_owner_;
   T* ptr_;
   DISALLOW_IMPLICIT_CONSTRUCTORS(WeakPtrFactory);
 };
 
 }  // namespace base
 
 #endif  // BASE_MEMORY_WEAK_PTR_H_