Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2142)

Unified Diff: content/renderer/v8_value_converter_impl_unittest.cc

Issue 10387055: Support optional arguments in SendRequestNatives::StartRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed John's comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/v8_value_converter_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/v8_value_converter_impl_unittest.cc
diff --git a/content/renderer/v8_value_converter_impl_unittest.cc b/content/renderer/v8_value_converter_impl_unittest.cc
index 44b4712fdf8e185cbc7158b1b8f5dfe98c830065..79f6105534fbb1bab9f60a2d1e4f7593dc4375e2 100644
--- a/content/renderer/v8_value_converter_impl_unittest.cc
+++ b/content/renderer/v8_value_converter_impl_unittest.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -293,14 +293,14 @@ TEST_F(V8ValueConverterImplTest, WeirdTypes) {
TestWeirdType(converter, v8::Date::New(1000), Value::TYPE_DICTIONARY, NULL);
TestWeirdType(converter, regex, Value::TYPE_DICTIONARY, NULL);
- converter.set_allow_undefined(true);
+ converter.SetUndefinedAllowed(true);
TestWeirdType(converter, v8::Undefined(), Value::TYPE_NULL, NULL);
- converter.set_allow_date(true);
+ converter.SetDateAllowed(true);
TestWeirdType(converter, v8::Date::New(1000), Value::TYPE_DOUBLE,
Value::CreateDoubleValue(1));
- converter.set_allow_regexp(true);
+ converter.SetRegexpAllowed(true);
TestWeirdType(converter, regex, Value::TYPE_STRING,
Value::CreateStringValue("/./"));
}
« no previous file with comments | « content/renderer/v8_value_converter_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698