chrome/renderer/extensions/send_request_natives.cc - Issue 10387055: Support optional arguments in SendRequestNatives::StartRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/send_request_natives.cc

Issue 10387055: Support optional arguments in SendRequestNatives::StartRequest (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed John's comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/send_request_natives.cc

diff --git a/chrome/renderer/extensions/send_request_natives.cc b/chrome/renderer/extensions/send_request_natives.cc

index 17e0ba995ade2e7239de66a92c9b399532f05e0f..5bf48e5f3c3bc2f175cffbebf4ae6b95a6b4ec70 100644

--- a/chrome/renderer/extensions/send_request_natives.cc

+++ b/chrome/renderer/extensions/send_request_natives.cc

@@ -41,6 +41,7 @@ v8::Handle<v8::Value> SendRequestNatives::StartRequest(

bool for_io_thread = args[4]->BooleanValue();

scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());

+ converter->SetUndefinedAllowed(true); // Allow passing optional values.

scoped_ptr<Value> value_args(

converter->FromV8Value(args[1], v8::Context::GetCurrent()));

if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) {

« no previous file with comments | « no previous file | content/public/renderer/v8_value_converter.h » ('j') | no next file with comments »