Support optional arguments in SendRequestNatives::StartRequest

content/renderer/v8_value_converter_impl.h

Index: content/renderer/v8_value_converter_impl.h
diff --git a/content/renderer/v8_value_converter_impl.h b/content/renderer/v8_value_converter_impl.h
index c43da46ab7489b42b0eac5369b47a107935a7fd1..f723f734d293dc6ea702048423f91fec606f4293 100644
--- a/content/renderer/v8_value_converter_impl.h
+++ b/content/renderer/v8_value_converter_impl.h
@@ -22,14 +22,14 @@ class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter {
 
   // Use the following setters to support additional types other than the

[jam, 2012/05/16 14:58:20]

nit: no need for this comment now that it's in the interface

[battre, 2012/05/16 16:11:12]

Done.

   // default ones.
-  bool allow_undefined() const { return allow_undefined_; }
-  void set_allow_undefined(bool val) { allow_undefined_ = val; }
+  virtual bool GetUndefinedAllowed() const OVERRIDE;
+  virtual void SetUndefinedAllowed(bool val) OVERRIDE;
 

[jam, 2012/05/16 14:58:20]

nit: no blank lines since these are overridden methods. also move them after the
comment on line 334

[battre, 2012/05/16 16:11:12]

Done.

-  bool allow_date() const { return allow_date_; }
-  void set_allow_date(bool val) { allow_date_ = val; }
+  virtual bool GetDateAllowed() const OVERRIDE;
+  virtual void SetDateAllowed(bool val) OVERRIDE;
 
-  bool allow_regexp() const { return allow_regexp_; }
-  void set_allow_regexp(bool val) { allow_regexp_ = val; }
+  virtual bool GetRegexpAllowed() const OVERRIDE;
+  virtual void SetRegexpAllowed(bool val) OVERRIDE;
 
   // V8ValueConverter implementation.
   virtual v8::Handle<v8::Value> ToV8Value(
@@ -57,13 +57,13 @@ class CONTENT_EXPORT V8ValueConverterImpl : public content::V8ValueConverter {
   base::DictionaryValue* FromV8Object(v8::Handle<v8::Object> object) const;
 
   // If true, we will convert undefined JavaScript values to null.
-  bool allow_undefined_;
+  bool undefined_allowed_;
 
   // If true, we will convert Date JavaScript objects to doubles.
-  bool allow_date_;
+  bool date_allowed_;
 
   // If true, we will convet RegExp JavaScript objects to string.
-  bool allow_regexp_;
+  bool regexp_allowed_;
 };
 
 #endif  // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_