frog/tests/leg/type_checker_test.dart - Issue 10387033: Add VoidElement and VoidType to make sure that there is a canonical void type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/tests/leg/type_checker_test.dart

Issue 10387033: Add VoidElement and VoidType to make sure that there is a canonical void type. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/tests/leg/type_checker_test.dart

diff --git a/frog/tests/leg/type_checker_test.dart b/frog/tests/leg/type_checker_test.dart

index 5581929946e5d53762ca67ae38ed4ca85217baad..ffb9f01b0192af24918d712472e0992ed070ba87 100644

--- a/frog/tests/leg/type_checker_test.dart

+++ b/frog/tests/leg/type_checker_test.dart

@@ -237,6 +237,8 @@ void testMethodInvocations() {

/** Tests analysis of returns (not required by the specification). */

void testControlFlow() {

+ analyzeTopLevel("void foo() { if (true) { return; } }");

+ analyzeTopLevel("foo() { if (true) { return; } }");

analyzeTopLevel("int foo() { if (true) { return 1; } }",

MessageKind.MAYBE_MISSING_RETURN);

final bar =

« no previous file with comments | « no previous file | lib/compiler/implementation/elements/elements.dart » ('j') | no next file with comments »