Add VoidElement and VoidType to make sure that there is a canonical void type.

lib/compiler/implementation/typechecker.dart

Index: lib/compiler/implementation/typechecker.dart
diff --git a/lib/compiler/implementation/typechecker.dart b/lib/compiler/implementation/typechecker.dart
index 6326ddb9f7667bc685b61b074ac6dd45032556bb..017005f1503d5bc2fe5e1f6de291d0ad2e58666a 100644
--- a/lib/compiler/implementation/typechecker.dart
+++ b/lib/compiler/implementation/typechecker.dart
@@ -60,6 +60,12 @@ class StatementType implements Type {
   String toString() => stringName;
 }
 
+class VoidType implements Type {
+  const VoidType(this.element);
+  SourceString get name() => Types.VOID;
+  final VoidElement element;
+}
+
 class InterfaceType implements Type {
   final Element element;
   final Link<Type> arguments;
@@ -111,7 +117,7 @@ class Types {
   static final OBJECT = const SourceString('Object');
   static final LIST = const SourceString('List');
 
-  final InterfaceType voidType;
+  final VoidType voidType;
   final InterfaceType dynamicType;
 
   Types(Element dynamicElement)
@@ -119,7 +125,7 @@ class Types {
 
   // TODO(karlklose): should we have a class Void?
   Types.with(Element dynamicElement, LibraryElement library)
-    : voidType = new InterfaceType(new ClassElement(VOID, library)),
+    : voidType = new VoidType(new VoidElement(library)),
       dynamicType = new InterfaceType(dynamicElement);
 
   Type lookup(SourceString s) {
@@ -135,7 +141,9 @@ class Types {
   bool isSubtype(Type t, Type s) {
     if (t === s || t === dynamicType || s === dynamicType ||
         s.name == OBJECT) return true;
-    if (t is InterfaceType) {
+    if (t is VoidType) {
+      return false;
+    } else if (t is InterfaceType) {
       if (s is !InterfaceType) return false;
       ClassElement tc = t.element;
       if (tc === s.element) return true;
@@ -578,16 +586,15 @@ class TypeCheckerVisitor implements Visitor<Type> {
   /** Dart Programming Language Specification: 11.10 Return */
   Type visitReturn(Return node) {
     final expression = node.expression;
-    final isVoidFunction =
-        (expectedReturnType.element === compiler.types.voidType.element);
+    final isVoidFunction = (expectedReturnType === types.voidType);
 
     // Executing a return statement return e; [...] It is a static type warning
     // if the type of e may not be assigned to the declared return type of the
     // immediately enclosing function.
     if (expression !== null) {
       final expressionType = analyze(expression);
-      if (isVoidFunction
-          && !types.isAssignable(expressionType, types.voidType)) {
+      if (isVoidFunction &&
+          !types.isAssignable(expressionType, types.voidType)) {

[ngeoffray, 2012/05/09 08:54:40]

Why this change? I think we followed Java's style conventions with the '&&' on
the new line.

[karlklose, 2012/05/09 10:32:41]

We certainly do not follow it everywhere in our code. But I am fine with either.
Reverted.

         reportTypeWarning(expression, MessageKind.RETURN_VALUE_IN_VOID,
                           [expressionType]);
       } else {