External file text search engine support.

External file text search engine support.

TL;DR Extends text search to embrace files external to the workspace so we can present matches in the SDK (and other resources analyzed but not explicitly open in the workspace).

Since this change is  bit sprawling, some context may help the review.  In a nutshell, this introduces a new set of abstractions (FileResource, FileResourceMatch and their specializations) to abstract over java.io.File and eclipse IResource searchables and retrofits the existing search architecture to embrace them.  Notable changes include:

  * broadening of the notion of text search scope to include external file roots
  * label provider and view content provider refinements
  * search execution refactorings to allow for the insertion of external resource traversals in the search
  * editor opener fixes to handle opening external resources
  * selection fixes to ensure matches are annotated in newly opened editors

With this change the default search scope has been extended to include the SDK libs.  SDK lib search matches are presented in a new node ("dart-sdk") in the search results view.
Committed: https://code.google.com/p/dart/source/detail?r=7419

[danrubel, 2012-05-08 00:22:43]

lgtm

http://codereview.chromium.org/10387008/diff/1/editor/tools/plugins/com.googl...
File
editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/core/text/TextSearchExecutor.java
(right):

http://codereview.chromium.org/10387008/diff/1/editor/tools/plugins/com.googl...
editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/core/text/TextSearchExecutor.java:80:
private Object /* <IFile,File> */file;
I recommend two fields... "file" and "resource"... both here and elsewhere. The
"file" field will always be non-null, while the "resource" field may be null if
the file does not map to a resource. That should everything more type safe.

Alternately, you could just have a "file" field and map to a resource when you
need it.

[pquitslund, 2012-05-08 15:58:25]

On 2012/05/08 00:22:43, danrubel wrote:
> lgtm
> 
>
http://codereview.chromium.org/10387008/diff/1/editor/tools/plugins/com.googl...
> File
>
editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/core/text/TextSearchExecutor.java
> (right):
> 
>
http://codereview.chromium.org/10387008/diff/1/editor/tools/plugins/com.googl...
>
editor/tools/plugins/com.google.dart.tools.search/src/com/google/dart/tools/search/internal/core/text/TextSearchExecutor.java:80:
> private Object /* <IFile,File> */file;
> I recommend two fields... "file" and "resource"... both here and elsewhere.
The
> "file" field will always be non-null, while the "resource" field may be null
if
> the file does not map to a resource. That should everything more type safe.
> 
> Alternately, you could just have a "file" field and map to a resource when you
> need it.

Cool.  Since this is such a mega change, I'll revisit in a follow-on.

[devoncarew, 2012-05-08 16:00:54]

lgtm

Looks good. I saw what looked like some whitespace only changes in there. I
think your next CL should add the new formatting settings files into this
plugin. If you then run a clean-up and a format over the files, that'll
level-set the project.

[keertip, 2012-05-08 16:07:18]

lgtm