Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3682)

Unified Diff: chrome/browser/chromeos/login/signed_settings.h

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r143931 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signed_settings.h
diff --git a/chrome/browser/chromeos/login/signed_settings.h b/chrome/browser/chromeos/login/signed_settings.h
index d9f7dd9d252cd43006b9079f7f779e01c47a9b0d..a1604630389a90bc74278232eb68a9ae2788c441 100644
--- a/chrome/browser/chromeos/login/signed_settings.h
+++ b/chrome/browser/chromeos/login/signed_settings.h
@@ -51,7 +51,6 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
};
SignedSettings();
- virtual ~SignedSettings();
// These are both "policy" operations, and only one instance of
// one type can be in flight at a time.
@@ -74,6 +73,8 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
const std::vector<uint8>& payload) = 0;
protected:
+ virtual ~SignedSettings();
+
static bool PolicyIsSane(
const enterprise_management::PolicyFetchResponse& value,
enterprise_management::PolicyData* poldata);
@@ -83,6 +84,7 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
OwnershipService* service_;
private:
+ friend class base::RefCountedThreadSafe<SignedSettings>;
friend class SignedSettingsTest;
friend class SignedSettingsHelperTest;
« no previous file with comments | « chrome/browser/chromeos/login/parallel_authenticator.cc ('k') | chrome/browser/chromeos/login/signed_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698