Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4946)

Unified Diff: chrome/browser/chromeos/login/help_app_launcher.h

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r143931 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/authenticator.cc ('k') | chrome/browser/chromeos/login/help_app_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/help_app_launcher.h
diff --git a/chrome/browser/chromeos/login/help_app_launcher.h b/chrome/browser/chromeos/login/help_app_launcher.h
index fddcb76583e1825040758ce132469f449f4d19e7..608cddf33f51d5fec6489299a472fae066c31e48 100644
--- a/chrome/browser/chromeos/login/help_app_launcher.h
+++ b/chrome/browser/chromeos/login/help_app_launcher.h
@@ -38,7 +38,6 @@ class HelpAppLauncher : public LoginWebDialog::Delegate,
// Parent window is used to show dialog.
explicit HelpAppLauncher(gfx::NativeWindow parent_window);
- virtual ~HelpAppLauncher();
// Shows specified help topic.
void ShowHelpTopic(HelpTopic help_topic_id);
@@ -47,10 +46,14 @@ class HelpAppLauncher : public LoginWebDialog::Delegate,
bool is_open() const { return dialog_.get() && dialog_->is_open(); }
protected:
+ virtual ~HelpAppLauncher();
+
// LoginWebDialog::Delegate implementation:
virtual void OnDialogClosed() OVERRIDE {}
private:
+ friend class base::RefCountedThreadSafe<HelpAppLauncher>;
+
// Shows help topic dialog for specified GURL.
void ShowHelpTopicDialog(const GURL& topic_url);
« no previous file with comments | « chrome/browser/chromeos/login/authenticator.cc ('k') | chrome/browser/chromeos/login/help_app_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698