Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_notifications.cc

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r143931 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_notifications.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_notifications.cc b/chrome/browser/chromeos/extensions/file_browser_notifications.cc
index 97800c06fa0b86579777f8416554cfc086ef7487..9f75b646ad96f00cedc9b1734a553a85e5b20e50 100644
--- a/chrome/browser/chromeos/extensions/file_browser_notifications.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_notifications.cc
@@ -104,7 +104,6 @@ class FileBrowserNotifications::NotificationMessage {
const std::string& id)
: host_(host),
id_(id) {}
- virtual ~Delegate() {}
virtual void Display() OVERRIDE {}
virtual void Error() OVERRIDE {}
virtual void Close(bool by_user) OVERRIDE {
@@ -120,6 +119,8 @@ class FileBrowserNotifications::NotificationMessage {
}
private:
+ virtual ~Delegate() {}
+
base::WeakPtr<FileBrowserNotifications> host_;
std::string id_;

Powered by Google App Engine
This is Rietveld 408576698