Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3393)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_handler_api.h

Issue 10386206: RefCounted types should not have public destructors, chromeos edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase to r143931 Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_handler_api.h
diff --git a/chrome/browser/chromeos/extensions/file_browser_handler_api.h b/chrome/browser/chromeos/extensions/file_browser_handler_api.h
index 407811cc3047a6bac8a9826e0849b45298c0e615..f9a1562d1904186bc97098548036ec0131168c7c 100644
--- a/chrome/browser/chromeos/extensions/file_browser_handler_api.h
+++ b/chrome/browser/chromeos/extensions/file_browser_handler_api.h
@@ -32,8 +32,9 @@ class FileSelector {
class FileHandlerSelectFileFunction : public AsyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserHandlerInternal.selectFile");
+
FileHandlerSelectFileFunction();
- virtual ~FileHandlerSelectFileFunction() OVERRIDE;
// Called by FileSelector implementation when the user selects new file's
// file path.
@@ -47,6 +48,7 @@ class FileHandlerSelectFileFunction : public AsyncExtensionFunction {
static void set_gesture_check_disabled_for_test(bool disabled);
protected:
+ virtual ~FileHandlerSelectFileFunction() OVERRIDE;
virtual bool RunImpl() OVERRIDE;
private:
@@ -87,8 +89,6 @@ class FileHandlerSelectFileFunction : public AsyncExtensionFunction {
// Once set they will be used for every extension function call.
static file_handler::FileSelector* file_selector_for_test_;
static bool gesture_check_disabled_for_test_;
-
- DECLARE_EXTENSION_FUNCTION_NAME("fileBrowserHandlerInternal.selectFile");
};
#endif // CHROME_BROWSER_CHROMEOS_EXTENSIONS_FILE_BROWSER_HANDLER_API_H_

Powered by Google App Engine
This is Rietveld 408576698