webkit/plugins/ppapi/resource_creation_impl.h - Issue 10386145: Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/resource_creation_impl.h

Issue 10386145: Add the necessary plumbing mechanisms to ensure proper WebGL support inside the <browser> tag, whic… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Shuffle EnterResource back out of the thunk layer Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ppapi/thunk/resource_creation_api.h ('K') | « webkit/plugins/ppapi/ppb_graphics_3d_impl.cc ('k') | webkit/plugins/ppapi/resource_creation_impl.cc » ('j') | webkit/plugins/ppapi/resource_creation_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webkit/plugins/ppapi/resource_creation_impl.h

diff --git a/webkit/plugins/ppapi/resource_creation_impl.h b/webkit/plugins/ppapi/resource_creation_impl.h

index ca8bb54cda10c38e80da9475e01af3f43ab3a301..d57e2ff2982ac5a74f15fe18ee7244c89dd6e467 100644

--- a/webkit/plugins/ppapi/resource_creation_impl.h

+++ b/webkit/plugins/ppapi/resource_creation_impl.h

@@ -56,12 +56,14 @@ class ResourceCreationImpl : public ::ppapi::thunk::ResourceCreationAPI {

virtual PP_Resource CreateGraphics2D(PP_Instance pp_instance,

const PP_Size& size,

PP_Bool is_always_opaque) OVERRIDE;

- virtual PP_Resource CreateGraphics3D(PP_Instance instance,

- PP_Resource share_context,

- const int32_t* attrib_list) OVERRIDE;

- virtual PP_Resource CreateGraphics3DRaw(PP_Instance instance,

- PP_Resource share_context,

- const int32_t* attrib_list) OVERRIDE;

+ virtual PP_Resource CreateGraphics3D(

+ PP_Instance instance,

Fady Samuel 2012/05/28 14:11:45 Hmm, it looks like the signature is the same. What

+ PP_Resource share_context,

+ const int32_t* attrib_list) OVERRIDE;

+ virtual PP_Resource CreateGraphics3DRaw(

+ PP_Instance instance,

+ PP_Resource share_context,

+ const int32_t* attrib_list) OVERRIDE;

virtual PP_Resource CreateHostResolverPrivate(PP_Instance instance) OVERRIDE;

virtual PP_Resource CreateImageData(PP_Instance instance,

PP_ImageDataFormat format,