chrome/browser/automation/automation_event_observers_chromeos.cc - Issue 10386144: Fixed a possible memory leak and support null pointers in AutomationEventObservers' NotifyEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/automation/automation_event_observers_chromeos.cc

Issue 10386144: Fixed a possible memory leak and support null pointers in AutomationEventObservers' NotifyEvent. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/automation/automation_event_observers.cc ('K') | « chrome/browser/automation/automation_event_observers.cc ('k') | chrome/browser/automation/automation_event_queue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/automation/automation_event_observers_chromeos.cc

diff --git a/chrome/browser/automation/automation_event_observers_chromeos.cc b/chrome/browser/automation/automation_event_observers_chromeos.cc

index 4d3d27d03ef4f71c237fee10f55c85de2834a8ca..7490ab820c94e7ee086986c8a00f590762256da6 100644

--- a/chrome/browser/automation/automation_event_observers_chromeos.cc

+++ b/chrome/browser/automation/automation_event_observers_chromeos.cc

@@ -29,7 +29,6 @@ void LoginEventObserver::OnLoginSuccess(const std::string& username,

void LoginEventObserver::_NotifyLoginEvent(const std::string& error_string) {

DictionaryValue* dict = new DictionaryValue;

dict->SetString("type", "login_event");

- dict->SetInteger("observer_id", GetId());

if (error_string.length())

dict->SetString("error_string", error_string);

NotifyEvent(dict);