Record API fix adding FirstRun, and allowing repeat-count in capture (plus some browsertests along …

chrome/browser/extensions/extension_record_api.h

Index: chrome/browser/extensions/extension_record_api.h
diff --git a/chrome/browser/extensions/extension_record_api.h b/chrome/browser/extensions/extension_record_api.h
index afd6cfd34e800c317beef24a3c653c7f4c1f209c..c55a1a612c30b9a76a09b7a312140a63e6413138 100644
--- a/chrome/browser/extensions/extension_record_api.h
+++ b/chrome/browser/extensions/extension_record_api.h
@@ -90,6 +90,7 @@ class RunPageCyclerFunction : public AsyncExtensionFunction {
 
   FilePath user_data_dir_;
   std::string url_contents_;
+  int repeat_count_;

[Aaron Boodman, 2012/05/16 23:37:00]

Why would you want to repeat the capture phase?

[clintstaley, 2012/05/31 01:54:30]

This was one of the necessary changes.  Apparently there is an incompatibility
with the captured cache if the repeat count differs between capture and replay. 
I've forgotten the details, but after some discussion we decided we had to put
the repeat count in the capture.

   std::vector<std::string> errors_;
 
   // Base CommandLine on which to build the test browser CommandLine
@@ -143,7 +144,6 @@ class ReplayURLsFunction : public RunPageCyclerFunction {
 
   // These three data are additional information added to the sub-browser
   // commandline.
-  int repeat_count_;
   FilePath extension_path_;
   FilePath stats_file_path_;