Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: net/base/host_resolver_impl.cc

Issue 10386120: Utility to resolve an hostname using Chromium's code in net/dns (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/host_resolver_impl.cc
diff --git a/net/base/host_resolver_impl.cc b/net/base/host_resolver_impl.cc
index 541246f8b4d3785d4f644bc3c0830120b668f660..8089b6c81c605be29ddc3cd17e23291b6b667f32 100644
--- a/net/base/host_resolver_impl.cc
+++ b/net/base/host_resolver_impl.cc
@@ -434,6 +434,8 @@ class PriorityTracker {
size_t counts_[NUM_PRIORITIES];
};
+} // anonymous namespace
+
//-----------------------------------------------------------------------------
HostResolver* CreateHostResolver(size_t max_concurrent_resolves,
@@ -459,10 +461,6 @@ HostResolver* CreateHostResolver(size_t max_concurrent_resolves,
return resolver;
}
-} // anonymous namespace
-
-//-----------------------------------------------------------------------------
-
HostResolver* CreateSystemHostResolver(size_t max_concurrent_resolves,
size_t max_retry_attempts,
NetLog* net_log) {
@@ -1070,6 +1068,7 @@ class HostResolverImpl::DnsTask {
base::Bind(&DnsTask::OnTransactionComplete, base::Unretained(this),
base::TimeTicks::Now()),
net_log_);
+
szym 2012/05/14 18:48:32 No need for this empty line.
Daniele 2012/05/17 23:04:34 Done.
DCHECK(transaction_.get());
}
@@ -1557,10 +1556,9 @@ HostResolverImpl::HostResolverImpl(
#endif
if (dns_config_service_.get()) {
- dns_config_service_->Watch(
- base::Bind(&HostResolverImpl::OnDnsConfigChanged,
- base::Unretained(this)));
dns_client_ = DnsClient::CreateClient(net_log_);
+ dns_config_service_->Watch(base::Bind(&HostResolverImpl::OnDnsConfigChanged,
szym 2012/05/14 18:48:32 Why did you change the order? I'm okay with the ne
Daniele 2012/05/17 23:04:34 I changed it because of the way I was calling the
+ base::Unretained(this)));
}
}

Powered by Google App Engine
This is Rietveld 408576698