Utility to resolve an hostname using Chromium's code in net/dns

net/tools/gdig/gdig.cc

+#include <stdio.h>

[szym, 2012/06/03 04:49:20]

Add the licence blurb.

[Daniele, 2012/06/04 20:01:14]

Done.

+#include <iostream>

[szym, 2012/06/03 04:49:20]

Don't use iostream. Use base/logging.h and LOG(INFO)/LOG(ERROR) instead.

[szym, 2012/06/03 20:00:05]

Also, need to include <string>

[Daniele, 2012/06/04 20:01:14]

Done.

+
+#include "base/at_exit.h"

[szym, 2012/06/03 20:00:05]

Include "base/bind.h", "base/cancelable_callback.h", "base/logging.h" (for
DCHECK) and "base/time.h".

[Daniele, 2012/06/04 20:01:14]

Done.

+#include "base/command_line.h"
+#if defined(OS_MACOSX)
+#include "base/mac/scoped_nsautorelease_pool.h"
+#endif
+#include "base/memory/scoped_ptr.h"
+#include "base/message_loop.h"
+#include "base/string_number_conversions.h"
+

[szym, 2012/06/03 04:49:20]

Unneeded blank line.

+#include "net/base/host_resolver_impl.h"

[szym, 2012/06/03 20:00:05]

Include "net/base/host_cache.h".

[Daniele, 2012/06/04 20:01:14]

Done.

+#include "net/base/net_errors.h"
+#include "net/base/net_util.h"
+#include "net/base/sys_addrinfo.h"

[szym, 2012/06/03 20:00:05]

Include "net/base/address_list.h" instead.

[Daniele, 2012/06/04 20:01:14]

Done.

+

[szym, 2012/06/03 04:49:20]

Ditto.

[Daniele, 2012/06/04 20:01:14]

Done.

+#include "net/dns/dns_client.h"

[szym, 2012/06/03 20:00:05]

Include "net/dns/dns_config_service.h".

[Daniele, 2012/06/04 20:01:14]

Done.

+
+namespace net {
+
+namespace {
+
+class GDig {
+ public:
+  GDig();
+
+  enum Result {
+    RESULT_NO_RESOLVE = -3,
+    RESULT_NO_CONFIG = -2,
+    RESULT_WRONG_USAGE = -1,
+    RESULT_OK = 0,
+  };
+
+  Result Main(int argc, const char* argv[]);
+
+ private:
+  bool ParseCommandLine(int argc, const char* argv[]);
+
+  void Start();
+
+  void OnDnsConfig(const DnsConfig& dns_config);
+  void OnResolveComplete(int val);
+  void OnTimeout();
+
+  base::TimeDelta timeout_;
+  std::string domain_name_;
+
+  Result result_;
+  AddressList addrlist_;
+
+  base::CancelableClosure timeout_closure_;
+  scoped_ptr<DnsConfigService> dns_config_service_;
+  scoped_ptr<HostResolver> resolver_;
+};
+
+GDig::GDig()
+    : timeout_(base::TimeDelta::FromSeconds(5)),
+      result_(GDig::RESULT_OK) {
+}
+
+GDig::Result GDig::Main(int argc, const char* argv[]) {
+  if (!ParseCommandLine(argc, argv)) {
+      std::cout << "usage: " << argv[0] <<
+          " [--config_timeout=<seconds>] domain_name" <<
+          std::endl;
+      return RESULT_WRONG_USAGE;
+  }
+
+#if defined(OS_MACOSX)
+  // Without this there will be a mem leak on osx

[szym, 2012/06/03 20:00:05]

nit: Add "." at end of sentence.

[Daniele, 2012/06/04 20:01:14]

Done.

+  base::mac::ScopedNSAutoreleasePool scoped_pool;
+#endif
+
+  base::AtExitManager exit_manager;
+  MessageLoopForIO loop;
+
+  Start();
+
+  MessageLoop::current()->Run();
+
+  // Destroy it while MessageLoopForIO is alive

[szym, 2012/06/03 20:00:05]

Ditto.

[Daniele, 2012/06/04 20:01:14]

Done.

+  dns_config_service_.reset();
+  return result_;
+}
+
+void GDig::OnResolveComplete(int val) {
+  MessageLoop::current()->Quit();
+  if (val != OK) {
+    std::cout << "Error trying to resolve hostname " << domain_name_ <<
+        ":" << ErrorToString(val) << std::endl;
+    result_ = RESULT_NO_RESOLVE;
+  } else {
+    for (AddressList::iterator i=addrlist_.begin(); i!=addrlist_.end(); ++i) {

[szym, 2012/06/03 20:00:05]

No strong opinion about it, but I think preference in net is for "for (size_t i
= 0; i < addrlist.size(); ++i)".
Also, add spaces around "=" and "!=".

[Daniele, 2012/06/04 20:01:14]

std::vector<IPEndPoint>::at is not exposed in AddressList, and I need it if we
want to use an index to iterate, should I expose it?

On 2012/06/03 20:00:05, szym wrote:

[szym, 2012/06/04 20:44:46]

operator[] is exposed.

+        std::cout << i->ToStringWithoutPort() << std::endl;

[szym, 2012/06/03 04:49:20]

nit: too much indent

[Daniele, 2012/06/04 20:01:14]

Done.

+    }
+  }
+}
+
+void GDig::OnTimeout() {
+  MessageLoop::current()->Quit();
+  std::cout << "Timed out waiting to load the dns config" << std::endl;
+  result_ = RESULT_NO_CONFIG;
+}
+
+void GDig::Start() {
+  dns_config_service_ = DnsConfigService::CreateSystemService();
+  dns_config_service_->Read(base::Bind(&GDig::OnDnsConfig,
+                                       base::Unretained(this)));
+
+  timeout_closure_.Reset(base::Bind(&GDig::OnTimeout, base::Unretained(this)));
+
+  MessageLoop::current()->PostDelayedTask(
+      FROM_HERE,
+      timeout_closure_.callback(),
+      timeout_);
+}
+
+void GDig::OnDnsConfig(const DnsConfig& dns_config) {
+  timeout_closure_.Cancel();
+  DCHECK(dns_config.IsValid());
+
+  scoped_ptr<DnsClient> dns_client(DnsClient::CreateClient(NULL));
+  dns_client->SetConfig(dns_config);
+  resolver_.reset(
+      new HostResolverImpl(
+          HostCache::CreateDefaultCache(),
+          PrioritizedDispatcher::Limits(NUM_PRIORITIES, 1),
+          HostResolverImpl::ProcTaskParams(NULL, 1),
+          scoped_ptr<DnsConfigService>(NULL),
+          dns_client.Pass(),
+          NULL));
+
+  HostResolver::RequestInfo info(HostPortPair(domain_name_.c_str(), 80));
+
+  CompletionCallback callback = base::Bind(&GDig::OnResolveComplete,
+                                           base::Unretained(this));
+  int ret = resolver_->Resolve(info, &addrlist_, callback, NULL, BoundNetLog());
+  DCHECK(ret == ERR_IO_PENDING);
+

[szym, 2012/06/03 20:00:05]

nit: Unneeded blank line.

[Daniele, 2012/06/04 20:01:14]

Done.

+}
+
+bool GDig::ParseCommandLine(int argc, const char* argv[]) {
+  CommandLine::Init(argc, argv);
+  const CommandLine& parsed_command_line = *CommandLine::ForCurrentProcess();
+
+  if (parsed_command_line.GetArgs().size() != 1) {

[szym, 2012/06/03 20:00:05]

No need for braces around single line body.

[Daniele, 2012/06/04 20:01:14]

Done.

+      return false;

[szym, 2012/06/03 04:49:20]

nit: too much indent

[Daniele, 2012/06/04 20:01:14]

Done.

+  }
+  domain_name_ = parsed_command_line.GetArgs().at(0);
+
+  if (parsed_command_line.HasSwitch("config_timeout")) {
+      int timeout_seconds = 0;

[szym, 2012/06/03 04:49:20]

Ditto.

[Daniele, 2012/06/04 20:01:14]

Done.

+      base::StringToInt(
+          parsed_command_line.GetSwitchValueASCII("config_timeout"),
+          &timeout_seconds);
+      timeout_ = base::TimeDelta::FromSeconds(timeout_seconds);
+  }
+
+  return true;
+}
+
+}  // empty namespace
+
+}  // namespace net
+
+int main(int argc, const char* argv[]) {
+  net::GDig dig;
+  return dig.Main(argc, argv);
+}