Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7263)

Unified Diff: chrome/browser/policy/network_configuration_updater_unittest.cc

Issue 10386097: Refactored ConfigurationPolicyProvider to provide PolicyBundles instead of PolicyMaps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/mock_configuration_policy_provider.cc ('k') | chrome/browser/policy/policy_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/network_configuration_updater_unittest.cc
diff --git a/chrome/browser/policy/network_configuration_updater_unittest.cc b/chrome/browser/policy/network_configuration_updater_unittest.cc
index bf6d71bab965d220f5a6cfeaf5266e387a05cac9..d03ee8bba15102e5679763fa3960be4326d8aee3 100644
--- a/chrome/browser/policy/network_configuration_updater_unittest.cc
+++ b/chrome/browser/policy/network_configuration_updater_unittest.cc
@@ -23,8 +23,6 @@ class NetworkConfigurationUpdaterTest
: public testing::TestWithParam<const char*> {
protected:
virtual void SetUp() OVERRIDE {
- EXPECT_CALL(provider_, ProvideInternal(_))
- .WillRepeatedly(CopyPolicyMap(&policy_));
EXPECT_CALL(network_library_, LoadOncNetworks(_, "", _, _))
.WillRepeatedly(Return(true));
}
@@ -40,13 +38,14 @@ class NetworkConfigurationUpdaterTest
}
chromeos::MockNetworkLibrary network_library_;
- PolicyMap policy_;
MockConfigurationPolicyProvider provider_;
};
TEST_P(NetworkConfigurationUpdaterTest, InitialUpdate) {
- policy_.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- Value::CreateStringValue(kFakeONC));
+ PolicyMap policy;
+ policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ Value::CreateStringValue(kFakeONC));
+ provider_.UpdateChromePolicy(policy);
EXPECT_CALL(network_library_,
LoadOncNetworks(kFakeONC, "", NameToONCSource(GetParam()), _))
@@ -63,16 +62,17 @@ TEST_P(NetworkConfigurationUpdaterTest, PolicyChange) {
EXPECT_CALL(network_library_,
LoadOncNetworks(kFakeONC, "", NameToONCSource(GetParam()), _))
.WillOnce(Return(true));
- policy_.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- Value::CreateStringValue(kFakeONC));
- provider_.NotifyPolicyUpdated();
+ PolicyMap policy;
+ policy.Set(GetParam(), POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ Value::CreateStringValue(kFakeONC));
+ provider_.UpdateChromePolicy(policy);
Mock::VerifyAndClearExpectations(&network_library_);
// No update if the set the same value again.
EXPECT_CALL(network_library_,
LoadOncNetworks(kFakeONC, "", NameToONCSource(GetParam()), _))
.Times(0);
- provider_.NotifyPolicyUpdated();
+ provider_.UpdateChromePolicy(policy);
Mock::VerifyAndClearExpectations(&network_library_);
// Another update is expected if the policy goes away.
@@ -80,8 +80,8 @@ TEST_P(NetworkConfigurationUpdaterTest, PolicyChange) {
LoadOncNetworks(NetworkConfigurationUpdater::kEmptyConfiguration,
"", NameToONCSource(GetParam()), _))
.WillOnce(Return(true));
- policy_.Erase(GetParam());
- provider_.NotifyPolicyUpdated();
+ policy.Erase(GetParam());
+ provider_.UpdateChromePolicy(policy);
Mock::VerifyAndClearExpectations(&network_library_);
}
« no previous file with comments | « chrome/browser/policy/mock_configuration_policy_provider.cc ('k') | chrome/browser/policy/policy_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698