Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: src/regexp-macro-assembler.h

Issue 10386090: Implement loop for global regexps in regexp assembler. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/regexp-macro-assembler.h
diff --git a/src/regexp-macro-assembler.h b/src/regexp-macro-assembler.h
index 85874358e5e87722b246bca6fc1e64af751af6ac..81875123200e942734aa8871eba90cdd7af287b2 100644
--- a/src/regexp-macro-assembler.h
+++ b/src/regexp-macro-assembler.h
@@ -1,4 +1,4 @@
-// Copyright 2008 the V8 project authors. All rights reserved.
+// Copyright 2012 the V8 project authors. All rights reserved.
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are
// met:
@@ -183,8 +183,14 @@ class RegExpMacroAssembler {
void set_slow_safe(bool ssc) { slow_safe_compiler_ = ssc; }
bool slow_safe() { return slow_safe_compiler_; }
+ // Set wether the regular expression has the global flag. Failures in a
Erik Corry 2012/05/11 11:01:00 A wether is a castrated billy-goat :-)
Yang 2012/05/16 14:58:47 Done. I never knew that. Learned something new tod
+ // global regexp may still mean success overal.
Erik Corry 2012/05/11 11:01:00 overall.
Yang 2012/05/16 14:58:47 Done.
+ void set_global(bool global) { global_ = global; }
+ bool global() { return global_; }
+
private:
bool slow_safe_compiler_;
+ bool global_;
};
@@ -249,6 +255,7 @@ class NativeRegExpMacroAssembler: public RegExpMacroAssembler {
const byte* input_start,
const byte* input_end,
int* output,
+ int output_size,
Isolate* isolate);
};

Powered by Google App Engine
This is Rietveld 408576698